Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: chrome/browser/thumbnails/simple_thumbnail_crop.h

Issue 1028393003: [Thumbnails] Specify copy size in Pixels, not DIPs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: correct rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/simple_thumbnail_crop.h
diff --git a/chrome/browser/thumbnails/simple_thumbnail_crop.h b/chrome/browser/thumbnails/simple_thumbnail_crop.h
index e54e5f233494c4ecf5f349dabb0a3e1fd550beb6..b206cc259b67e9968725cea473f3fa16359e4cac 100644
--- a/chrome/browser/thumbnails/simple_thumbnail_crop.h
+++ b/chrome/browser/thumbnails/simple_thumbnail_crop.h
@@ -21,7 +21,7 @@ class SimpleThumbnailCrop : public ThumbnailingAlgorithm {
ClipResult GetCanvasCopyInfo(const gfx::Size& source_size,
ui::ScaleFactor scale_factor,
gfx::Rect* clipping_rect,
- gfx::Size* target_size) const override;
+ gfx::Size* copy_size) const override;
void ProcessBitmap(scoped_refptr<ThumbnailingContext> context,
const ConsumerCallback& callback,
@@ -37,6 +37,8 @@ class SimpleThumbnailCrop : public ThumbnailingAlgorithm {
int desired_width,
int desired_height,
thumbnails::ClipResult* clip_result);
+ // Returns the size copied from the backing store. |thumbnail_size| is in
+ // DIP, returned size in pixels.
static gfx::Size GetCopySizeForThumbnail(ui::ScaleFactor scale_factor,
const gfx::Size& thumbnail_size);
static gfx::Rect GetClippingRect(const gfx::Size& source_size,
@@ -57,6 +59,7 @@ class SimpleThumbnailCrop : public ThumbnailingAlgorithm {
const gfx::Size& desired_size,
ClipResult* clip_result);
+ // The target size of the captured thumbnails, in DIPs.
const gfx::Size target_size_;
DISALLOW_COPY_AND_ASSIGN(SimpleThumbnailCrop);
« no previous file with comments | « chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc ('k') | chrome/browser/thumbnails/simple_thumbnail_crop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698