sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 102833008: Revert "Dummy receiver optimization"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 102833008: Revert "Dummy receiver optimization" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index 6b9a62ceaba9e6df13b5a571d9749b874d30769c..835a673ec5c7e4d150ff29c11dcbc0c949577619 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -909,9 +909,8 @@ class CodeEmitterTask extends CompilerTask {

}

bool isConstantInlinedOrAlreadyEmitted(Constant constant) {

- if (constant.isFunction()) return true; // Already emitted.

- if (constant.isPrimitive()) return true; // Inlined.

- if (constant.isDummyReceiver()) return true; // Inlined.

+ if (constant.isFunction()) return true; // Already emitted.

+ if (constant.isPrimitive()) return true; // Inlined.

// The name is null when the constant is already a JS constant.

// TODO(floitsch): every constant should be registered, so that we can

// share the ones that take up too much space (like some strings).