Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 102833007: Add base:: to string16 in rlz/. (Closed)

Created:
7 years ago by Dan Beam
Modified:
7 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : missed one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M rlz/chromeos/lib/machine_id_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/ios/lib/machine_id_ios.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/lib/machine_id.h View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/lib/machine_id.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M rlz/lib/machine_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/mac/lib/machine_id_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/test/rlz_test_helpers.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M rlz/win/lib/machine_id_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
7 years ago (2013-12-19 05:50:02 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
7 years ago (2013-12-19 13:44:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/102833007/20001
7 years ago (2013-12-19 17:28:52 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-19 18:47:53 UTC) #4
Message was sent while issue was closed.
Change committed as 241896

Powered by Google App Engine
This is Rietveld 408576698