Issue 102833003: DevTools: Add a checkbox to enable async stacks in the sidebar header.

Issue 102833003: DevTools: Add a checkbox to enable async stacks in the sidebar header. (Closed)

Created:
7 years ago by aandrey

Modified:
7 years ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Add a checkbox to enable async stacks in the sidebar header. This also removes the checkbox from the Settings page. BUG=272416 R=pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163448

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -152 lines)			Patch
M	Source/devtools/front_end/CallStackSidebarPane.js	View	1	6 chunks	+47 lines, -30 lines	0 comments	Download
M	Source/devtools/front_end/DebuggerModel.js	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/Placard.js	View		2 chunks	+0 lines, -109 lines	0 comments	Download
M	Source/devtools/front_end/Settings.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/SettingsScreen.js	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sidebarPane.css	View	1	5 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/102833003/diff/1/Source/devtools/front_end/CallStackSidebarPane.js File Source/devtools/front_end/CallStackSidebarPane.js (right): https://codereview.chromium.org/102833003/diff/1/Source/devtools/front_end/CallStackSidebarPane.js#newcode37 Source/devtools/front_end/CallStackSidebarPane.js:37: asyncCheckbox.classList.add("async"); Please use full-qualified styles: scripts-callstack-async

7 years ago (2013-12-09 16:56:44 UTC) #2

pfeldman

https://codereview.chromium.org/102833003/diff/1/Source/devtools/front_end/CallStackSidebarPane.js File Source/devtools/front_end/CallStackSidebarPane.js (right): https://codereview.chromium.org/102833003/diff/1/Source/devtools/front_end/CallStackSidebarPane.js#newcode121 Source/devtools/front_end/CallStackSidebarPane.js:121: if (!enabled && this.placards.length) this.placards is null here in ...

7 years ago (2013-12-09 16:59:31 UTC) #3

aandrey

https://codereview.chromium.org/102833003/diff/1/Source/devtools/front_end/CallStackSidebarPane.js File Source/devtools/front_end/CallStackSidebarPane.js (right): https://codereview.chromium.org/102833003/diff/1/Source/devtools/front_end/CallStackSidebarPane.js#newcode37 Source/devtools/front_end/CallStackSidebarPane.js:37: asyncCheckbox.classList.add("async"); On 2013/12/09 16:56:44, pfeldman wrote: > Please use ...

7 years ago (2013-12-09 17:03:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/102833003/20001

7 years ago (2013-12-09 17:04:34 UTC) #5

Message was sent while issue was closed.

Change committed as 163448

Expand Messages | Collapse Messages