Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: src/ic/ppc/handler-compiler-ppc.cc

Issue 1028323002: PPC: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 704 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 Label miss; 715 Label miss;
716 if (IC::ICUseVector(kind())) { 716 if (IC::ICUseVector(kind())) {
717 PushVectorAndSlot(); 717 PushVectorAndSlot();
718 } 718 }
719 FrontendHeader(receiver(), name, &miss); 719 FrontendHeader(receiver(), name, &miss);
720 720
721 // Get the value from the cell. 721 // Get the value from the cell.
722 Register result = StoreDescriptor::ValueRegister(); 722 Register result = StoreDescriptor::ValueRegister();
723 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell); 723 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
724 __ LoadWeakValue(result, weak_cell, &miss); 724 __ LoadWeakValue(result, weak_cell, &miss);
725 __ LoadP(result, FieldMemOperand(result, Cell::kValueOffset)); 725 __ LoadP(result, FieldMemOperand(result, PropertyCell::kValueOffset));
726 726
727 // Check for deleted property if property can actually be deleted. 727 // Check for deleted property if property can actually be deleted.
728 if (is_configurable) { 728 if (is_configurable) {
729 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 729 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
730 __ cmp(result, ip); 730 __ cmp(result, ip);
731 __ beq(&miss); 731 __ beq(&miss);
732 } 732 }
733 733
734 Counters* counters = isolate()->counters(); 734 Counters* counters = isolate()->counters();
735 __ IncrementCounter(counters->named_load_global_stub(), 1, r4, r6); 735 __ IncrementCounter(counters->named_load_global_stub(), 1, r4, r6);
736 if (IC::ICUseVector(kind())) { 736 if (IC::ICUseVector(kind())) {
737 DiscardVectorAndSlot(); 737 DiscardVectorAndSlot();
738 } 738 }
739 __ Ret(); 739 __ Ret();
740 740
741 FrontendFooter(name, &miss); 741 FrontendFooter(name, &miss);
742 742
743 // Return the generated code. 743 // Return the generated code.
744 return GetCode(kind(), Code::NORMAL, name); 744 return GetCode(kind(), Code::NORMAL, name);
745 } 745 }
746 746
747 747
748 #undef __ 748 #undef __
749 } 749 }
750 } // namespace v8::internal 750 } // namespace v8::internal
751 751
752 #endif // V8_TARGET_ARCH_ARM 752 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698