chromeos/network/onc/onc_signature.cc - Issue 1028243007: Call Device.SetCarrier when the ONC Carrier property is specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_signature.cc

Issue 1028243007: Call Device.SetCarrier when the ONC Carrier property is specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@onc_clang

Patch Set: . Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/managed_network_configuration_handler_impl.cc ('K') | « chromeos/network/mock_managed_network_configuration_handler.h ('k') | components/onc/onc_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/network/onc/onc_signature.cc

diff --git a/chromeos/network/onc/onc_signature.cc b/chromeos/network/onc/onc_signature.cc

index 568d150a27d03946c40ee57cb29a9b42841e7d5d..b001afe96af0e0836157b4e0a797f85c07da72e1 100644

--- a/chromeos/network/onc/onc_signature.cc

+++ b/chromeos/network/onc/onc_signature.cc

@@ -263,14 +263,14 @@ const OncFieldSignature cellular_fields[] = {

{::onc::kRecommended, &kRecommendedSignature},

{::onc::cellular::kAPN, &kCellularApnSignature},

{::onc::cellular::kAPNList, &kCellularApnListSignature},

- {::onc::vpn::kAutoConnect, &kBoolSignature},

+ {::onc::cellular::kCarrier, &kStringSignature},

+ {::onc::cellular::kAutoConnect, &kBoolSignature},

pneubeck (no reviews) 2015/03/27 18:26:46 please also fix all usages, e.g.: https://code.goo

stevenjb 2015/03/27 23:18:04 Done.

{NULL}};

const OncFieldSignature cellular_with_state_fields[] = {

{::onc::cellular::kActivationType, &kStringSignature},

{::onc::cellular::kActivationState, &kStringSignature},

{::onc::cellular::kAllowRoaming, &kBoolSignature},

- {::onc::cellular::kCarrier, &kStringSignature},

{::onc::cellular::kESN, &kStringSignature},

{::onc::cellular::kFamily, &kStringSignature},

{::onc::cellular::kFirmwareRevision, &kStringSignature},