Call Device.SetCarrier when the ONC Carrier property is specified.

chrome/test/data/extensions/api_test/networking_private/chromeos/test.js

Index: chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
diff --git a/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js b/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
index c0550b3aff182d0a8c066f1eda4cd1ca780c3b13..b86c786f38cd631334d4a95bf85f758648945b0b 100644
--- a/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
+++ b/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
@@ -424,9 +424,40 @@ var availableTests = [
                  }, result);
       }));
   },
+  function setCellularProperties() {
+    var network_guid = 'stub_cellular1_guid';
+    // Make sure we test

[pneubeck (no reviews), 2015/03/27 18:26:46]

?

[stevenjb, 2015/03/27 23:18:04]

Oops. Fixed.

+    var newCarrier = 'new_carrier';
+    chrome.networkingPrivate.getProperties(
+        network_guid,
+        callbackPass(function(result) {
+          assertEq(network_guid, result.GUID);
+          assertFalse(result.Cellular && result.Cellular.Carrier == newCarrier);

[pneubeck (no reviews), 2015/03/27 18:26:46]

assertTrue(result.Cellular && result.Cellular.Carrier != newCarrier) ?
otherwise you accept a !result.Cellular

maybe complete it to:
assertTrue(result.Cellular);
assertTrue(result.Cellular.Carrier != newCarrier);
assertTrue(result.Priority != 1);

(note that you usually tried to use
  'abc' in XY
and XY['abc']
)

[stevenjb, 2015/03/27 23:18:04]

We don't actually care if Cellular exists, we just need to ensure that it isn't
initially 'new_carrier', otherwise we wouldn't actually be testing whether or
not it was set. I inverted the logic, hopefully that is more readable.

+          var new_properties = {
+            Priority: 1,
+            Cellular: {
+              Carrier: newCarrier,
+            },
+          };
+          chrome.networkingPrivate.setProperties(
+              network_guid,
+              new_properties,
+              callbackPass(function() {
+                chrome.networkingPrivate.getProperties(
+                    network_guid,
+                    callbackPass(function(result) {
+                      // Ensure that the GUID doesn't change.
+                      assertEq(network_guid, result.GUID);
+                      // Ensure that the properties were set.
+                      assertEq(1, result['Priority']);
+                      assertTrue('Cellular' in result);
+                      assertEq(newCarrier, result.Cellular.Carrier);
+                    }));
+              }));
+        }));
+  },
   function setWiFiProperties() {
-    var done = chrome.test.callbackAdded();
-    var network_guid = "stub_wifi1_guid";
+    var network_guid = 'stub_wifi1_guid';
     chrome.networkingPrivate.getProperties(
         network_guid,
         callbackPass(function(result) {
@@ -458,14 +489,12 @@ var availableTests = [
                       assertTrue('StaticIPConfig' in result);
                       assertEq('1.2.3.4',
                                result['StaticIPConfig']['IPAddress']);
-                      done();
                     }));
               }));
         }));
   },
   function setVPNProperties() {
-    var done = chrome.test.callbackAdded();
-    var network_guid = "stub_vpn1_guid";
+    var network_guid = 'stub_vpn1_guid';
     chrome.networkingPrivate.getProperties(
         network_guid,
         callbackPass(function(result) {
@@ -490,7 +519,6 @@ var availableTests = [
                       assertEq('vpn.host1', result['VPN']['Host']);
                       // Ensure that the GUID doesn't change.
                       assertEq(network_guid, result.GUID);
-                      done();
                     }));
               }));
         }));