Call Device.SetCarrier when the ONC Carrier property is specified.

chrome/test/data/extensions/api_test/networking_private/chromeos/test.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The expectations in this test for the Chrome OS implementation. See
 // networking_private_chromeos_apitest.cc for more info.
 
 var callbackPass = chrome.test.callbackPass;
 var callbackFail = chrome.test.callbackFail;
 var assertTrue = chrome.test.assertTrue;
@@ skipping 406 matching lines @@
                      "Security": {
                        "Active": "WPA-PSK",
                        "Effective": "UserPolicy",
                        "UserPolicy": "WPA-PSK"
                      },
                      "SignalStrength": 80,
                    }
                  }, result);
       }));
   },
-  function setWiFiProperties() {
-    var done = chrome.test.callbackAdded();
-    var network_guid = "stub_wifi1_guid";
+  function setCellularProperties() {
+    var network_guid = 'stub_cellular1_guid';
+    // Make sure we test

[pneubeck (no reviews), 2015/03/27 18:26:46]

?

[stevenjb, 2015/03/27 23:18:04]

Oops. Fixed.

+    var newCarrier = 'new_carrier';
     chrome.networkingPrivate.getProperties(
         network_guid,
         callbackPass(function(result) {
+          assertEq(network_guid, result.GUID);
+          assertFalse(result.Cellular && result.Cellular.Carrier == newCarrier);

[pneubeck (no reviews), 2015/03/27 18:26:46]

assertTrue(result.Cellular && result.Cellular.Carrier != newCarrier) ?
otherwise you accept a !result.Cellular

maybe complete it to:
assertTrue(result.Cellular);
assertTrue(result.Cellular.Carrier != newCarrier);
assertTrue(result.Priority != 1);

(note that you usually tried to use
  'abc' in XY
and XY['abc']
)

[stevenjb, 2015/03/27 23:18:04]

We don't actually care if Cellular exists, we just need to ensure that it isn't
initially 'new_carrier', otherwise we wouldn't actually be testing whether or
not it was set. I inverted the logic, hopefully that is more readable.

+          var new_properties = {
+            Priority: 1,
+            Cellular: {
+              Carrier: newCarrier,
+            },
+          };
+          chrome.networkingPrivate.setProperties(
+              network_guid,
+              new_properties,
+              callbackPass(function() {
+                chrome.networkingPrivate.getProperties(
+                    network_guid,
+                    callbackPass(function(result) {
+                      // Ensure that the GUID doesn't change.
+                      assertEq(network_guid, result.GUID);
+                      // Ensure that the properties were set.
+                      assertEq(1, result['Priority']);
+                      assertTrue('Cellular' in result);
+                      assertEq(newCarrier, result.Cellular.Carrier);
+                    }));
+              }));
+        }));
+  },
+  function setWiFiProperties() {
+    var network_guid = 'stub_wifi1_guid';
+    chrome.networkingPrivate.getProperties(
+        network_guid,
+        callbackPass(function(result) {
           assertEq(network_guid, result.GUID);
           var new_properties = {
             Priority: 1,
             WiFi: {
               AutoConnect: true
             },
             IPAddressConfigType: 'Static',
             StaticIPConfig: {
               IPAddress: '1.2.3.4'
             }
           };
           chrome.networkingPrivate.setProperties(
               network_guid,
               new_properties,
               callbackPass(function() {
                 chrome.networkingPrivate.getProperties(
                     network_guid,
                     callbackPass(function(result) {
                       // Ensure that the GUID doesn't change.
                       assertEq(network_guid, result.GUID);
                       // Ensure that the properties were set.
                       assertEq(1, result['Priority']);
                       assertTrue('WiFi' in result);
                       assertTrue('AutoConnect' in result['WiFi']);
                       assertEq(true, result['WiFi']['AutoConnect']);
                       assertTrue('StaticIPConfig' in result);
                       assertEq('1.2.3.4',
                                result['StaticIPConfig']['IPAddress']);
-                      done();
                     }));
               }));
         }));
   },
   function setVPNProperties() {
-    var done = chrome.test.callbackAdded();
-    var network_guid = "stub_vpn1_guid";
+    var network_guid = 'stub_vpn1_guid';
     chrome.networkingPrivate.getProperties(
         network_guid,
         callbackPass(function(result) {
           assertEq(network_guid, result.GUID);
           var new_properties = {
             Priority: 1,
             VPN: {
               Host: 'vpn.host1'
             }
           };
           chrome.networkingPrivate.setProperties(
               network_guid,
               new_properties,
               callbackPass(function() {
                 chrome.networkingPrivate.getProperties(
                     network_guid,
                     callbackPass(function(result) {
                       // Ensure that the properties were set.
                       assertEq(1, result['Priority']);
                       assertTrue('VPN' in result);
                       assertTrue('Host' in result['VPN']);
                       assertEq('vpn.host1', result['VPN']['Host']);
                       // Ensure that the GUID doesn't change.
                       assertEq(network_guid, result.GUID);
-                      done();
                     }));
               }));
         }));
   },
   function getState() {
     chrome.networkingPrivate.getState(
       "stub_wifi2_guid",
       callbackPass(function(result) {
         assertEq({
           "Connectable": true,
@@ skipping 107 matching lines @@
         new privateHelpers.watchForCaptivePortalState(
             'wifi_guid', 'Online', done);
     chrome.test.sendMessage('notifyPortalDetectorObservers');
   },
 ];
 
 var testToRun = window.location.search.substring(1);
 chrome.test.runTests(availableTests.filter(function(op) {
   return op.name == testToRun;
 }));