chrome/browser/ui/passwords/manage_passwords_ui_controller.cc - Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a Mac test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon_mock.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

index bbc7c14eee211c763cc3dfb86ee12600ae46ff0d..cba75401d0cda884cf6daacb29abf59e68e60791 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

@@ -218,11 +218,8 @@ void ManagePasswordsUIController::ChooseCredential(

void ManagePasswordsUIController::SavePasswordInternal() {

password_manager::PasswordFormManager* form_manager =

passwords_data_.form_manager();

- // TODO(vasilii): it's not OK to call SavePassword() when |form_manager| is 0.

- // If this is a cause of http://crbug.com/468474 then we should hide the

- // bubble when ManagePasswordsUIController changes its internal state.

- if (form_manager)

- form_manager->Save();

+ DCHECK(form_manager);

+ form_manager->Save();

}

void ManagePasswordsUIController::NeverSavePassword() {