Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h

Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Mac Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
diff --git a/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h b/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
index fb23053286629d65b136041c52aa46590374192f..90738866afb1f35f71435312cbc03ab6e8ed2e2a 100644
--- a/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
+++ b/chrome/browser/ui/cocoa/location_bar/manage_passwords_decoration.h
@@ -23,6 +23,7 @@ class ManagePasswordsIconCocoa : public ManagePasswordsIcon {
ManagePasswordsIconCocoa(ManagePasswordsDecoration* decoration);
virtual ~ManagePasswordsIconCocoa();
void UpdateVisibleUI() override;
+ void OnChangingState() override;
int icon_id() { return icon_id_; }
int tooltip_text_id() { return tooltip_text_id_; }
@@ -48,6 +49,9 @@ class ManagePasswordsDecoration : public ImageDecoration {
// Updates the decoration according to icon state changes.
void UpdateVisibleUI();
+ // Closes the it's currently displayed.
vabr (Chromium) 2015/03/25 11:43:24 grammar: This comment appears to have broken gramm
vasilii 2015/03/25 11:48:55 Done.
+ void HideBubble();
+
// Accessor for the platform-independent interface.
ManagePasswordsIconCocoa* icon() { return icon_.get(); }

Powered by Google App Engine
This is Rietveld 408576698