Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_icon.h

Issue 1028243004: Hide the password bubble when the underlying ManagePasswordsUIController changes its state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Mac Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "components/password_manager/core/common/password_manager_ui.h" 9 #include "components/password_manager/core/common/password_manager_ui.h"
10 10
(...skipping 10 matching lines...) Expand all
21 bool active() const { return active_; } 21 bool active() const { return active_; }
22 22
23 protected: 23 protected:
24 // The ID of the icon and text resources that are currently displayed. 24 // The ID of the icon and text resources that are currently displayed.
25 int icon_id_; 25 int icon_id_;
26 int tooltip_text_id_; 26 int tooltip_text_id_;
27 27
28 ManagePasswordsIcon(); 28 ManagePasswordsIcon();
29 ~ManagePasswordsIcon(); 29 ~ManagePasswordsIcon();
30 30
31 // Called from SetState() iff the icon's state has changed in order to do 31 // Called from SetState() and SetActive() in order to do whatever
32 // whatever platform-specific UI work is necessary given the new state. 32 // platform-specific UI work is necessary.
33 virtual void UpdateVisibleUI() = 0; 33 virtual void UpdateVisibleUI() = 0;
34 34
35 // Called from SetState() iff the icon's state has changed in order to close
vabr (Chromium) 2015/03/25 11:43:24 nit: Is the "in order to close the current bubble"
vasilii 2015/03/25 11:48:55 Done.
36 // the current bubble.
37 virtual void OnChangingState() = 0;
38
35 private: 39 private:
36 // Updates the resource IDs in response to state changes. 40 // Updates the resource IDs in response to state changes.
37 void UpdateIDs(); 41 void UpdateIDs();
38 42
39 password_manager::ui::State state_; 43 password_manager::ui::State state_;
40 bool active_; 44 bool active_;
41 45
42 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIcon); 46 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIcon);
43 }; 47 };
44 48
45 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_H_ 49 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698