Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1028243003: Let Dart code running in Sky add events to the trace timeline (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, ojan
CC:
ojan, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Let Dart code running in Sky add events to the trace timeline This will let us form a wholistic picture of work done in the framework and in the engine. R=ojan@chromium.org, rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/806d6642bbe6e3d26e692c2231660147e0818612

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -32 lines) Patch
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.h View 3 chunks +4 lines, -1 line 0 comments Download
M sky/engine/core/frame/LocalDOMWindow.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
A sky/engine/core/frame/Tracing.h View 1 chunk +30 lines, -0 lines 0 comments Download
A sky/engine/core/frame/Tracing.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
A + sky/engine/core/frame/Tracing.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M sky/engine/core/frame/Window.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/script/dart_controller.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sky/examples/stocks-fn/lib/stock_app.dart View 1 2 chunks +4 lines, -1 line 0 comments Download
M sky/examples/stocks-fn/lib/stock_data.dart View 1 2 chunks +9 lines, -10 lines 0 comments Download
M sky/framework/components/fixed_height_scrollable.dart View 1 2 chunks +18 lines, -15 lines 0 comments Download
M sky/framework/fn.dart View 3 chunks +7 lines, -2 lines 0 comments Download
A sky/framework/tracing.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-23 20:21:44 UTC) #1
rafaelw
lgtm
5 years, 9 months ago (2015-03-23 21:19:34 UTC) #2
ojan
lgtm
5 years, 9 months ago (2015-03-23 21:20:42 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-23 21:48:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
806d6642bbe6e3d26e692c2231660147e0818612 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698