Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 1028243002: Validate that zip entry filenames are UTF8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/download_protection_service.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc
index ba2592be3c90b04e8d8615780447a0b9a8737ab8..6939ca0290ca949586ec41e7d4791904f2f57d1d 100644
--- a/chrome/browser/safe_browsing/download_protection_service.cc
+++ b/chrome/browser/safe_browsing/download_protection_service.cc
@@ -590,7 +590,10 @@ class DownloadProtectionService::CheckClientDownloadRequest
archived_binary_.CopyFrom(results.archived_binary);
DVLOG(1) << "Zip analysis finished for " << item_->GetFullPath().value()
<< ", has_executable=" << results.has_executable
- << " has_archive=" << results.has_archive;
+ << " has_archive=" << results.has_archive
+ << " has_unsafe_file=" << results.has_unsafe_file;
+ UMA_HISTOGRAM_BOOLEAN("SBClientDownload.ZipFileHasUnsafeFile",
+ results.has_unsafe_file);
} else {
DVLOG(1) << "Zip analysis failed for " << item_->GetFullPath().value();
}
« no previous file with comments | « no previous file | chrome/common/safe_browsing/zip_analyzer.cc » ('j') | chrome/common/safe_browsing/zip_analyzer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698