tools/metrics/histograms/histograms.xml - Issue 1028243002: Validate that zip entry filenames are UTF8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1028243002: Validate that zip entry filenames are UTF8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index bc7a43e7e94c75b84eaca3097f58a92f08b2a715..31e94ff2de596804004fdae6444ac2637223ce91 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -32659,6 +32659,14 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="SBClientDownload.ZipFileHasUnsafeFile" enum="BooleanHit">

Mark P 2015/03/24 18:13:34 Do you feel that BooleanHit is somehow more approp

+ <owner>grt@chromium.org</owner>

+ <summary>

+ Hit if a zip file analyzed by the SafeBrowsing download service contains a

+ file with an unsafe name.

Mark P 2015/03/24 18:13:34 For clarity, perhaps add something like (if true):

+ </summary>

+</histogram>

<owner>noelutz@chromium.org</owner>