Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc

Issue 1028213002: Destroy configurations created by VPN extension on disable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
diff --git a/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc b/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
index 017df6b74386719d48bd1c823ffe29f7d8ad5017..4d63df25915b6da7fe7e3dd6231fec0f014ac842 100644
--- a/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
+++ b/chrome/browser/extensions/api/vpn_provider/vpn_provider_apitest.cc
@@ -418,4 +418,30 @@ IN_PROC_BROWSER_TEST_F(VpnProviderApiTest, CreateUninstall) {
->GetService(service_path, &profile_path, &properties));
}
+IN_PROC_BROWSER_TEST_F(VpnProviderApiTest, CreateDisable) {
+ LoadVpnExtension();
+ AddNetworkProfileForUser();
+ EXPECT_TRUE(RunExtensionTest("createConfigSuccess"));
+ EXPECT_TRUE(DoesConfigExist(kTestConfig));
+
+ const std::string service_path = GetSingleServicePath();
+ std::string profile_path;
+ base::DictionaryValue properties;
+ EXPECT_TRUE(DBusThreadManager::Get()
+ ->GetShillProfileClient()
+ ->GetTestInterface()
+ ->GetService(service_path, &profile_path, &properties));
+
+ ExtensionService* extension_service =
+ extensions::ExtensionSystem::Get(profile())->extension_service();
+ extension_service->DisableExtension(extension_id_,
+ extensions::Extension::DISABLE_NONE);
+ content::RunAllPendingInMessageLoop();
+ EXPECT_FALSE(DoesConfigExist(kTestConfig));
+ EXPECT_FALSE(DBusThreadManager::Get()
+ ->GetShillProfileClient()
+ ->GetTestInterface()
+ ->GetService(service_path, &profile_path, &properties));
+}
+
} // namespace chromeos
« no previous file with comments | « no previous file | extensions/browser/api/vpn_provider/vpn_service.h » ('j') | extensions/browser/api/vpn_provider/vpn_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698