Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: test/isolaterunner_test.dart

Issue 1028193003: pkg/isolate: fix checked-mode running of isolaterunner_test (Closed) Base URL: https://github.com/dart-lang/isolate.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/isolaterunner_test.dart
diff --git a/test/isolaterunner_test.dart b/test/isolaterunner_test.dart
index 4b98b587faf42ec74190340b243169eb57e9e9a0..9b0b3b6695731c296a8c87afe40e4d08d6ad0998 100644
--- a/test/isolaterunner_test.dart
+++ b/test/isolaterunner_test.dart
@@ -111,4 +111,4 @@ id(x) => x;
var _global;
getGlobal(_) => _global;
-void setGlobal(v) => _global = v;
+setGlobal(v) => _global = v;
Lasse Reichstein Nielsen 2015/03/24 10:41:23 I prefer void setGlobal(v) { _global = v; }
kevmoo 2015/03/24 13:10:29 No you don't. A test fails if it doesn't return th
Lasse Reichstein Nielsen 2015/03/24 18:38:11 Ack, a "setter" with a meaningful return value. M
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698