Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1028173002: SVGPathParser: Move unaltered emits to a separate code-path (Closed)

Created:
5 years, 9 months ago by fs
Modified:
5 years, 9 months ago
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

SVGPathParser: Move unaltered emits to a separate code-path Hoist the check for normalized parsing/normalization out of the emit* methods, and with it the non-normalized emittal out of emit*. This type of emittal is trivial, so the use of SVGPathParser::m_mode can be avoided altogther in this code-path. This leaves the emit* methods with only doing normalized emittals, and SVGPathParser::m_pathParsingMode only needs to be checked in the main parsing method, so it becomes possible to just use the parameter directly. BUG=467592 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -95 lines) Patch
M Source/core/svg/SVGPathParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathParser.cpp View 11 chunks +112 lines, -94 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
This CL moves SVGPathParser into (one of a couple) of intermediate states in preparation for ...
5 years, 9 months ago (2015-03-23 14:52:32 UTC) #2
f(malita)
On 2015/03/23 14:52:32, fs wrote: > This CL moves SVGPathParser into (one of a couple) ...
5 years, 9 months ago (2015-03-23 15:19:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028173002/1
5 years, 9 months ago (2015-03-23 15:32:09 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 15:39:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192369

Powered by Google App Engine
This is Rietveld 408576698