components/autofill/content/renderer/password_form_conversion_utils.h - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.h

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('j') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/password_form_conversion_utils.h

diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h

index d5fa13fa91447a2ac42fd03742ad5b60f07bbaa5..48b805124c2e6a07e24ae67ab4e081775fddbdf7 100644

--- a/components/autofill/content/renderer/password_form_conversion_utils.h

+++ b/components/autofill/content/renderer/password_form_conversion_utils.h

@@ -6,6 +6,7 @@

#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H_

#include <map>

+#include <vector>

#include "base/memory/scoped_ptr.h"

@@ -17,6 +18,7 @@ class WebString;

namespace autofill {

+struct FormDataPredictions;

struct PasswordForm;

// Create a PasswordForm from DOM form. Webkit doesn't allow storing

@@ -29,7 +31,8 @@ struct PasswordForm;

scoped_ptr<PasswordForm> CreatePasswordForm(

const blink::WebFormElement& form,

const std::map<const blink::WebInputElement, blink::WebString>*

- nonscript_modified_values);

+ nonscript_modified_values,

+ const std::vector<autofill::FormDataPredictions>* form_predictions);

vabr (Chromium) 2015/03/23 16:48:23 nit: Please add a comment about the new argument.

dvadym 2015/03/23 17:20:44 Added comment // |form_predictions| is Autofill se

} // namespace autofill