components/autofill/core/common/password_form.h - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form.h

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small nit Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/core/browser/test_autofill_driver.cc ('k') | components/autofill/core/common/password_form.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form.h

diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h

index bbcf72ae0fc09c9962492ec4c7a2bd9aada3573b..06d1ad51cbc998c65a5adaa76e6887477dd4b968 100644

--- a/components/autofill/core/common/password_form.h

+++ b/components/autofill/core/common/password_form.h

@@ -256,6 +256,9 @@ struct PasswordForm {

// The layout as determined during parsing. Default value is LAYOUT_OTHER.

Layout layout;

+ // If true, this form was parsed using Autofill predictions.

+ bool parsed_using_autofill_predictions;

Ilya Sherman 2015/03/31 00:45:04 nit: I'd name this with a "was_" prefix, i.e. "was

dvadym 2015/03/31 09:54:03 Done.

// Returns true if this match was found using public suffix matching.

bool IsPublicSuffixMatch() const;