Processing USERNAME reply from Autofill server in Password Manager

components/autofill/content/common/autofill_messages.h

Index: components/autofill/content/common/autofill_messages.h
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h
index 078ff83427e4180bbe7fb03dd7fcedfae5f70d44..d3e7f52187c196f2c8a763feeaf5b9df56cd3ae4 100644
--- a/components/autofill/content/common/autofill_messages.h
+++ b/components/autofill/content/common/autofill_messages.h
@@ -102,6 +102,9 @@ IPC_ENUM_TRAITS_MAX_VALUE(
     blink::WebFormElement::AutocompleteResult,
     blink::WebFormElement::AutocompleteResultErrorInvalid)
 
+typedef std::map<autofill::FormData, autofill::FormFieldData>
+    FormDataFieldDataMap;

[Ilya Sherman, 2015/03/26 00:30:04]

I'm really not thrilled about defining a typedef in an IPC messages file. 
Please inline this type name.

[dvadym, 2015/03/26 12:29:12]

I can't do it directly, because comma after FormData is considered as comma
between arguments in macros IPC_MESSAGE_ROUTED1, that causes compilation errors.
I didn't find other cases how to do with map. Can you advice what to do with map
args?

+
 // Autofill messages sent from the browser to the renderer.
 
 // Tells the render frame that a user gesture was observed somewhere in the tab
@@ -195,6 +198,12 @@ IPC_MESSAGE_ROUTED3(AutofillMsg_RequestAutocompleteResult,
 IPC_MESSAGE_ROUTED1(AutofillMsg_AccountCreationFormsDetected,
                     std::vector<autofill::FormData> /* forms */)
 
+// Sent when Autofill manager gets the query response from the Autofill server
+// which contains information about username fields for some forms.
+// |predictions| maps forms to their username fields.
+IPC_MESSAGE_ROUTED1(AutofillMsg_AutofillUsernameDataReceived,
+                    FormDataFieldDataMap /* predictions */)

[Ilya Sherman, 2015/03/26 00:30:04]

Why is an IPC message needed?  It seems like this information should be managed
by the browser process.  The renderer process should not be involved.  What am I
missing?

[dvadym, 2015/03/26 12:29:12]

I've tried to explain it in separate message.

+
 // Autofill messages sent from the renderer to the browser.
 
 // TODO(creis): check in the browser that the renderer actually has permission