chrome/browser/ui/autofill/chrome_autofill_client.cc - Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/chrome_autofill_client.cc

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed many reviewer comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/chrome_autofill_client.h ('k') | chrome/renderer/autofill/password_autofill_agent_browsertest.cc » ('j') | chrome/renderer/autofill/password_autofill_agent_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/chrome_autofill_client.cc

diff --git a/chrome/browser/ui/autofill/chrome_autofill_client.cc b/chrome/browser/ui/autofill/chrome_autofill_client.cc

index 173f3bf3badb1196b5be31e00b91519a3992a11d..11871d774bd05bb97c0a0ccc5474f17eb6b269ce 100644

--- a/chrome/browser/ui/autofill/chrome_autofill_client.cc

+++ b/chrome/browser/ui/autofill/chrome_autofill_client.cc

@@ -264,14 +264,16 @@ void ChromeAutofillClient::OnZoomChanged(

HideAutofillPopup();

}

-void ChromeAutofillClient::DetectAccountCreationForms(

+void ChromeAutofillClient::PropagateAutofillPredictions(

content::RenderFrameHost* rfh,

const std::vector<autofill::FormStructure*>& forms) {

password_manager::ContentPasswordManagerDriver* driver =

password_manager::ContentPasswordManagerDriver::GetForRenderFrameHost(

rfh);

- if (driver)

+ if (driver) {

driver->GetPasswordGenerationManager()->DetectAccountCreationForms(forms);

+ driver->GetPasswordManager()->ProcessAutofillPredictions(driver, forms);

+ }

}

void ChromeAutofillClient::DidFillOrPreviewField(