Processing USERNAME reply from Autofill server in Password Manager

components/password_manager/core/browser/password_manager.cc

Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index 3d6111c7e6ef1c33c0a48a895906ca0b255cfabe..42ca800865c7fe9a9f357ca64abdb20e39fff80c 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -11,6 +11,9 @@
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/platform_thread.h"
+#include "components/autofill/core/browser/autofill_field.h"
+#include "components/autofill/core/browser/form_structure.h"
+#include "components/autofill/core/common/form_data_predictions.h"
 #include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
 #include "components/password_manager/core/browser/password_autofill_manager.h"
 #include "components/password_manager/core/browser/password_form_manager.h"
@@ -718,4 +721,22 @@ void PasswordManager::Autofill(password_manager::PasswordManagerDriver* driver,
   client_->PasswordWasAutofilled(best_matches);
 }
 
+void PasswordManager::ProcessAutofillPredictions(
+    password_manager::PasswordManagerDriver* driver,
+    const std::vector<autofill::FormStructure*>& forms) {
+  // Leave only forms that contain fields that are useful for password manager.
+  std::map<autofill::FormData, autofill::FormFieldData> predictions;
+  for (auto form : forms) {

[vabr (Chromium), 2015/03/25 10:12:34]

TL;DR autofill::FormStructure* is short enough that replacing it with auto
actually harms readability.

More detail: In general, the trade-off between auto and a full type is:
auto helps avoid German-style words in type names
precise type helps to understand what the iterating variable is

Because autofill::FormStructure* is far from German-style :), the benefits of
auto are too small.

[dvadym, 2015/03/25 16:34:08]

Done.

+    for (auto it = form->begin(); it != form->end(); ++it) {

[vabr (Chromium), 2015/03/25 10:12:34]

Here I would also vote against auto, although the direct type name is much more
German-style than above.
for (std::vector<AutofillField*>::const_iterator field = form->begin(); field !=
form->end(); ++field) {...}

The reason is that FormStructure is not a container, so it is at all not clear
what begin() and end() do on it. Also please note changing |it| to a more
meaningful |field|, so that it is clear that the iterator represents a field.

[dvadym, 2015/03/25 16:34:08]

Done.

+      if ((*it)->server_type() == autofill::USERNAME ||
+          (*it)->server_type() == autofill::USERNAME_AND_EMAIL_ADDRESS) {
+        predictions[form->ToFormData()] = *(*it);
+      }
+    }
+  }
+  if (predictions.empty())
+    return;
+  driver->AutofillDataReceived(predictions);
+}
+
 }  // namespace password_manager