Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: components/autofill/content/renderer/password_form_conversion_utils.h

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test and changed sending message Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_form_conversion_utils.h
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.h b/components/autofill/content/renderer/password_form_conversion_utils.h
index d5fa13fa91447a2ac42fd03742ad5b60f07bbaa5..d39f63f332323e302940d2fb3a2fcd2355327067 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.h
+++ b/components/autofill/content/renderer/password_form_conversion_utils.h
@@ -6,6 +6,7 @@
#define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_FORM_CONVERSION_UTILS_H_
#include <map>
+#include <vector>
vabr (Chromium) 2015/03/25 10:12:33 Seems unused.
dvadym 2015/03/25 16:34:08 Done.
#include "base/memory/scoped_ptr.h"
@@ -17,6 +18,8 @@ class WebString;
namespace autofill {
+struct FormData;
+struct FormFieldData;
struct PasswordForm;
// Create a PasswordForm from DOM form. Webkit doesn't allow storing
@@ -26,10 +29,14 @@ struct PasswordForm;
// If an element of |form| has an entry in |nonscript_modified_values|, the
// associated string is used instead of the element's value to create
// the PasswordForm.
+// |form_predictions| is Autofill server response, if present it's used for
+// overwriting default username element selection.
scoped_ptr<PasswordForm> CreatePasswordForm(
const blink::WebFormElement& form,
const std::map<const blink::WebInputElement, blink::WebString>*
- nonscript_modified_values);
+ nonscript_modified_values,
+ const std::map<autofill::FormData, autofill::FormFieldData>*
+ form_predictions);
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698