Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1028163002: Processing USERNAME reply from Autofill server in Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added test and changed sending message Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index 720f97bbc7ab1d3485c7490e11aeedb8e0d0ee06..717068f1bce2cf21c65bb3c0d538cd1203aa9431 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -11,6 +11,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
+#include "components/autofill/core/common/form_data_predictions.h"
#include "components/autofill/core/common/password_form_fill_data.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/public/renderer/render_view_observer.h"
@@ -102,6 +103,7 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
typedef std::map<blink::WebElement, int> LoginToPasswordInfoKeyMap;
typedef std::map<blink::WebInputElement, blink::WebInputElement>
PasswordToLoginMap;
+ std::map<autofill::FormData, autofill::FormFieldData> form_predictions_;
// This class keeps track of autofilled password input elements and makes sure
// the autofilled password value is not accessible to JavaScript code until
@@ -173,6 +175,10 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
// RenderView IPC handlers:
void OnFillPasswordForm(int key, const PasswordFormFillData& form_data);
void OnSetLoggingState(bool active);
+ void OnAutofillDataReceived(
+ const std::map<autofill::FormData, autofill::FormFieldData>& predictions);
+ FRIEND_TEST_ALL_PREFIXES(PasswordAutofillAgentTest,
+ FindingUsernameWithAutofillPredictions);
Garrett Casto 2015/03/24 23:31:50 Don't friend here. Instead just send a message in
dvadym 2015/03/25 16:34:07 Done.
// Scans the given frame for password forms and sends them up to the browser.
// If |only_visible| is true, only forms visible in the layout are sent.

Powered by Google App Engine
This is Rietveld 408576698