Processing USERNAME reply from Autofill server in Password Manager

components/autofill/core/common/password_form.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ostream>
 
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/password_form.h"
 
 namespace autofill {
 
 PasswordForm::PasswordForm()
     : scheme(SCHEME_HTML),
       username_marked_by_site(false),
       password_autocomplete_set(true),
       ssl_valid(false),
       preferred(false),
       blacklisted_by_user(false),
       type(TYPE_MANUAL),
       times_used(0),
       generation_upload_status(NO_SIGNAL_SENT),
-      skip_zero_click(false) {
+      skip_zero_click(false),
+      parsed_using_autofill_predictions(false) {
 }
 
 PasswordForm::~PasswordForm() {
 }
 
 bool PasswordForm::IsPublicSuffixMatch() const {
   return !original_signon_realm.empty();
 }
 
 bool PasswordForm::operator==(const PasswordForm& form) const {
@@ skipping 17 matching lines @@
       date_created == form.date_created &&
       date_synced == form.date_synced &&
       blacklisted_by_user == form.blacklisted_by_user &&
       type == form.type &&
       times_used == form.times_used &&
       form_data.SameFormAs(form.form_data) &&
       generation_upload_status == form.generation_upload_status &&
       display_name == form.display_name &&
       avatar_url == form.avatar_url &&
       federation_url == form.federation_url &&
       skip_zero_click == form.skip_zero_click;

[vabr (Chromium), 2015/03/25 10:12:33]

Please add a test for parsed_using_autofill_predictions.

[dvadym, 2015/03/25 16:34:08]

Done.

 }
 
 bool PasswordForm::operator!=(const PasswordForm& form) const {
   return !operator==(form);
 }
 
 std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {
   return os << "scheme: " << form.scheme
             << " signon_realm: " << form.signon_realm
             << " original_signon_realm: " << form.original_signon_realm
@@ skipping 17 matching lines @@
             << " ssl_valid: " << form.ssl_valid
             << " date_created: " << form.date_created.ToDoubleT()
             << " date_synced: " << form.date_synced.ToDoubleT()
             << " type: " << form.type
             << " times_used: " << form.times_used
             << " form_data: " << form.form_data
             << " generation_upload_status: " << form.generation_upload_status
             << " display_name: " << base::UTF16ToUTF8(form.display_name)
             << " avatar_url: " << form.avatar_url
             << " federation_url: " << form.federation_url
             << " skip_next_zero_click: " << form.skip_zero_click;

[vabr (Chromium), 2015/03/25 10:12:33]

Please add parsed_using_autofill_predictions (however, beware of
https://codereview.chromium.org/1022823002/ being almost ready to land, so the
logging might change).

[dvadym, 2015/03/25 16:34:08]

Done.

 }
 
 }  // namespace autofill