Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 102813007: Add fontconfig to linux DEPS for embedded builds (Closed)

Created:
7 years ago by spang
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add fontconfig to linux DEPS for embedded builds We'll use this in-tree fontconfig when "embedded=1" is set in GYP_DEFINES. BUG=318315 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243381

Patch Set 1 #

Patch Set 2 : add /src to checkout path #

Patch Set 3 : add README.chromium, fontconfig.gyp, generated files #

Patch Set 4 : fix license file path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6915 lines, --6 lines) Patch
M DEPS View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/fontconfig/README.chromium View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/fontconfig/fontconfig.gyp View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/config.h View 1 2 1 chunk +360 lines, -0 lines 0 comments Download
A + third_party/fontconfig/include/fc-case/fcalias.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/fontconfig/include/fc-case/fcaliastail.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/fontconfig/include/fc-case/fccase.h View 1 2 1 chunk +330 lines, -0 lines 0 comments Download
A + third_party/fontconfig/include/fc-glyphname/fcalias.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/fontconfig/include/fc-glyphname/fcaliastail.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/fontconfig/include/fc-glyphname/fcglyphname.h View 1 2 1 chunk +781 lines, -0 lines 0 comments Download
A + third_party/fontconfig/include/fc-lang/fcalias.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/fontconfig/include/fc-lang/fcaliastail.h View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/fontconfig/include/fc-lang/fclang.h View 1 2 1 chunk +4176 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/src/fcalias.h View 1 2 1 chunk +390 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/src/fcaliastail.h View 1 2 1 chunk +440 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/src/fcftalias.h View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/src/fcftaliastail.h View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/src/fcobjshash.h View 1 2 1 chunk +317 lines, -0 lines 0 comments Download
A third_party/fontconfig/include/src/fcstdint.h View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
spang
7 years ago (2013-12-18 18:21:05 UTC) #1
rjkroege
lgtm
7 years ago (2013-12-18 18:25:33 UTC) #2
darin (slow to review)
LGTM
7 years ago (2013-12-18 19:24:37 UTC) #3
spang
On 2013/12/18 19:24:37, darin wrote: > LGTM Overlooked something: we need to add a gyp ...
7 years ago (2013-12-18 20:13:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/102813007/20001
7 years ago (2013-12-18 20:13:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=134455
7 years ago (2013-12-18 21:48:29 UTC) #6
spang
On 2013/12/18 21:48:29, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years ago (2013-12-18 23:43:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/102813007/60001
6 years, 11 months ago (2014-01-07 17:35:15 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 21:28:24 UTC) #9
Message was sent while issue was closed.
Change committed as 243381

Powered by Google App Engine
This is Rietveld 408576698