chrome/browser/supervised_user/permission_request_creator.h - Issue 1028123002: Supervised users: Include extension version in update requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/permission_request_creator.h

Issue 1028123002: Supervised users: Include extension version in update requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit_tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc ('k') | chrome/browser/supervised_user/supervised_user_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/permission_request_creator.h

diff --git a/chrome/browser/supervised_user/permission_request_creator.h b/chrome/browser/supervised_user/permission_request_creator.h

index 549f0c9d49779c17e299cee7cd80ede8b3f63ed4..de31ebd3547521418319ec74ac409a374196c3e2 100644

--- a/chrome/browser/supervised_user/permission_request_creator.h

+++ b/chrome/browser/supervised_user/permission_request_creator.h

@@ -28,10 +28,10 @@ class PermissionRequestCreator {

virtual void CreateURLAccessRequest(const GURL& url_requested,

const SuccessCallback& callback) = 0;

- // Creates a request to re-enable the extension with the given |extension_id|,

- // which was disabled due to a permission increase.

+ // Creates a request to re-enable the extension with the given |id| (composed

+ // of extension_id:version), which was disabled due to a permission increase.

virtual void CreateExtensionUpdateRequest(

- const std::string& extension_id,

+ const std::string& id,

const SuccessCallback& callback) = 0;

};