chrome/browser/extensions/extension_service_unittest.cc - Issue 1028123002: Supervised users: Include extension version in update requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 1028123002: Supervised users: Include extension version in update requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit_tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service_unittest.cc

diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc

index 7d1a0db9c32352e7516aec32d9aa244629dbe223..ba02841a42b11295310c78fbba2a9a1595008ce3 100644

--- a/chrome/browser/extensions/extension_service_unittest.cc

+++ b/chrome/browser/extensions/extension_service_unittest.cc

@@ -6642,7 +6642,7 @@ class MockPermissionRequestCreator : public PermissionRequestCreator {

}

MOCK_METHOD2(CreateExtensionUpdateRequest,

- void(const std::string& extension_id,

+ void(const std::string& id,

const SupervisedUserService::SuccessCallback& callback));

private:

@@ -6737,7 +6737,8 @@ TEST_F(ExtensionServiceTest, SupervisedUser_UpdateWithPermissionIncrease) {

std::string old_version = extension->VersionString();

// Update to a new version with increased permissions.

- EXPECT_CALL(*creator, CreateExtensionUpdateRequest(id, testing::_));

+ EXPECT_CALL(*creator,

+ CreateExtensionUpdateRequest(id + ":2", testing::_));

path = base_path.AppendASCII("v2");

PackCRXAndUpdateExtension(id, path, pem_path, DISABLED);