chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc - Issue 1028123002: Supervised users: Include extension version in update requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

Issue 1028123002: Supervised users: Include extension version in update requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc ('K') | « chrome/browser/supervised_user/legacy/permission_request_creator_sync.h ('k') | chrome/browser/supervised_user/permission_request_creator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

diff --git a/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc b/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

index 0bba1cee1790a06e106c36936bd8aa7e8d529a0c..bacb1ada25d331dee8287d07bff7c9ce48630efa 100644

--- a/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

+++ b/chrome/browser/supervised_user/legacy/permission_request_creator_sync.cc

@@ -6,6 +6,7 @@

#include "base/callback.h"

#include "base/values.h"

+#include "base/version.h"

#include "chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.h"

#include "chrome/browser/supervised_user/supervised_user_settings_service.h"

#include "chrome/browser/sync/profile_sync_service.h"

@@ -58,8 +59,10 @@ void PermissionRequestCreatorSync::CreateURLAccessRequest(

void PermissionRequestCreatorSync::CreateExtensionUpdateRequest(

const std::string& extension_id,

+ const base::Version& version,

const SuccessCallback& callback) {

- CreateRequest(kSupervisedUserUpdateRequestKeyPrefix, extension_id, callback);

+ std::string data = extension_id + ":" + version.GetString();

+ CreateRequest(kSupervisedUserUpdateRequestKeyPrefix, data, callback);

}

void PermissionRequestCreatorSync::CreateRequest(