Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7055)

Unified Diff: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc

Issue 1028123002: Supervised users: Include extension version in update requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
diff --git a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
index 668fe4a1d642da52bba3ec697bd56eb7c11a1e92..d06e5728499adef82bbe1e5247d64765c4a43cc3 100644
--- a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
+++ b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc
@@ -11,6 +11,7 @@
#include "base/logging.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
+#include "base/version.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
#include "chrome/browser/signin/signin_manager_factory.h"
@@ -118,8 +119,10 @@ void PermissionRequestCreatorApiary::CreateURLAccessRequest(
void PermissionRequestCreatorApiary::CreateExtensionUpdateRequest(
const std::string& extension_id,
+ const base::Version& version,
const SuccessCallback& callback) {
- CreateRequest(kNamespaceUpdateRequest, extension_id, callback);
+ std::string object_ref = extension_id + ":" + version.GetString();
Bernhard Bauer 2015/03/23 16:18:39 BTW, is there a reason why this is part of the Per
Marc Treib 2015/03/23 16:26:46 I'd say it's only by coincidence that both PRC imp
Bernhard Bauer 2015/03/23 16:51:48 Really? IMO it's fair to say that what we are abst
Marc Treib 2015/03/24 14:48:03 Done.
+ CreateRequest(kNamespaceUpdateRequest, object_ref, callback);
}
GURL PermissionRequestCreatorApiary::GetApiUrl() const {

Powered by Google App Engine
This is Rietveld 408576698