VectorICs: keyed element loads were kicking out non-smi keys unnecessarily

test/mjsunit/string-index.js

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 232 matching lines @@
 var keys = [0, 10];
 var str = 'ab', arr = ['a', undefined];
 for (var i = 0; i < 100; ++i) {
   var index = Math.floor(i / 50);
   var key = keys[index];
   var expected = arr[index];
   var actual = str[key];
   assertEquals(expected, actual);
 }
 
+// Test out of range with a heap number case.
+Math.abs(-343.2);
+var keys = [0, Math.abs(2)];

[Yang, 2015/03/23 14:23:59]

You probably should check that this is not a smi via %IsSmi

[mvstanton, 2015/03/23 15:54:45]

Done. And the Math.floor(x) * 0.5 trick seems to work better than abs().

+var str = 'ab', arr = ['a', undefined];
+for (var i = 0; i < 100; ++i) {
+  var index = Math.floor(i / 50);
+  var key = keys[index];
+  var expected = arr[index];
+  var actual = str[key];
+  assertEquals(expected, actual);
+}
+
 // Test two byte string.
 var str = '\u0427', arr = ['\u0427'];
 for (var i = 0; i < 50; ++i) {
   var expected = arr[0];
   var actual = str[0];
   assertEquals(expected, actual);
 }