Chromium Code Reviews

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1028093002: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Turn off --vector-ics flag. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 4084 matching lines...)
4095 __ LoadRoot(result, Heap::kNanValueRootIndex); 4095 __ LoadRoot(result, Heap::kNanValueRootIndex);
4096 __ jmp(&done); 4096 __ jmp(&done);
4097 4097
4098 __ bind(&need_conversion); 4098 __ bind(&need_conversion);
4099 // Load the undefined value into the result register, which will 4099 // Load the undefined value into the result register, which will
4100 // trigger conversion. 4100 // trigger conversion.
4101 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 4101 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
4102 __ jmp(&done); 4102 __ jmp(&done);
4103 4103
4104 NopRuntimeCallHelper call_helper; 4104 NopRuntimeCallHelper call_helper;
4105 generator.GenerateSlow(masm_, call_helper); 4105 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4106 4106
4107 __ bind(&done); 4107 __ bind(&done);
4108 context()->Plug(result); 4108 context()->Plug(result);
4109 } 4109 }
4110 4110
4111 4111
4112 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4112 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4113 ZoneList<Expression*>* args = expr->arguments(); 4113 ZoneList<Expression*>* args = expr->arguments();
4114 DCHECK(args->length() == 2); 4114 DCHECK(args->length() == 2);
4115 4115
(...skipping 28 matching lines...)
4144 __ LoadRoot(result, Heap::kempty_stringRootIndex); 4144 __ LoadRoot(result, Heap::kempty_stringRootIndex);
4145 __ jmp(&done); 4145 __ jmp(&done);
4146 4146
4147 __ bind(&need_conversion); 4147 __ bind(&need_conversion);
4148 // Move smi zero into the result register, which will trigger 4148 // Move smi zero into the result register, which will trigger
4149 // conversion. 4149 // conversion.
4150 __ li(result, Operand(Smi::FromInt(0))); 4150 __ li(result, Operand(Smi::FromInt(0)));
4151 __ jmp(&done); 4151 __ jmp(&done);
4152 4152
4153 NopRuntimeCallHelper call_helper; 4153 NopRuntimeCallHelper call_helper;
4154 generator.GenerateSlow(masm_, call_helper); 4154 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4155 4155
4156 __ bind(&done); 4156 __ bind(&done);
4157 context()->Plug(result); 4157 context()->Plug(result);
4158 } 4158 }
4159 4159
4160 4160
4161 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4161 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4162 ZoneList<Expression*>* args = expr->arguments(); 4162 ZoneList<Expression*>* args = expr->arguments();
4163 DCHECK_EQ(2, args->length()); 4163 DCHECK_EQ(2, args->length());
4164 VisitForStackValue(args->at(0)); 4164 VisitForStackValue(args->at(0));
(...skipping 1291 matching lines...)
5456 Assembler::target_address_at(pc_immediate_load_address)) == 5456 Assembler::target_address_at(pc_immediate_load_address)) ==
5457 reinterpret_cast<uint32_t>( 5457 reinterpret_cast<uint32_t>(
5458 isolate->builtins()->OsrAfterStackCheck()->entry())); 5458 isolate->builtins()->OsrAfterStackCheck()->entry()));
5459 return OSR_AFTER_STACK_CHECK; 5459 return OSR_AFTER_STACK_CHECK;
5460 } 5460 }
5461 5461
5462 5462
5463 } } // namespace v8::internal 5463 } } // namespace v8::internal
5464 5464
5465 #endif // V8_TARGET_ARCH_MIPS 5465 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine