Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 1028093002: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Turn off --vector-ics flag. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3982 matching lines...) Expand 10 before | Expand all | Expand 10 after
3993 __ Move(result, Immediate(isolate()->factory()->nan_value())); 3993 __ Move(result, Immediate(isolate()->factory()->nan_value()));
3994 __ jmp(&done); 3994 __ jmp(&done);
3995 3995
3996 __ bind(&need_conversion); 3996 __ bind(&need_conversion);
3997 // Move the undefined value into the result register, which will 3997 // Move the undefined value into the result register, which will
3998 // trigger conversion. 3998 // trigger conversion.
3999 __ Move(result, Immediate(isolate()->factory()->undefined_value())); 3999 __ Move(result, Immediate(isolate()->factory()->undefined_value()));
4000 __ jmp(&done); 4000 __ jmp(&done);
4001 4001
4002 NopRuntimeCallHelper call_helper; 4002 NopRuntimeCallHelper call_helper;
4003 generator.GenerateSlow(masm_, call_helper); 4003 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4004 4004
4005 __ bind(&done); 4005 __ bind(&done);
4006 context()->Plug(result); 4006 context()->Plug(result);
4007 } 4007 }
4008 4008
4009 4009
4010 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4010 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4011 ZoneList<Expression*>* args = expr->arguments(); 4011 ZoneList<Expression*>* args = expr->arguments();
4012 DCHECK(args->length() == 2); 4012 DCHECK(args->length() == 2);
4013 4013
(...skipping 27 matching lines...) Expand all
4041 __ Move(result, Immediate(isolate()->factory()->empty_string())); 4041 __ Move(result, Immediate(isolate()->factory()->empty_string()));
4042 __ jmp(&done); 4042 __ jmp(&done);
4043 4043
4044 __ bind(&need_conversion); 4044 __ bind(&need_conversion);
4045 // Move smi zero into the result register, which will trigger 4045 // Move smi zero into the result register, which will trigger
4046 // conversion. 4046 // conversion.
4047 __ Move(result, Immediate(Smi::FromInt(0))); 4047 __ Move(result, Immediate(Smi::FromInt(0)));
4048 __ jmp(&done); 4048 __ jmp(&done);
4049 4049
4050 NopRuntimeCallHelper call_helper; 4050 NopRuntimeCallHelper call_helper;
4051 generator.GenerateSlow(masm_, call_helper); 4051 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4052 4052
4053 __ bind(&done); 4053 __ bind(&done);
4054 context()->Plug(result); 4054 context()->Plug(result);
4055 } 4055 }
4056 4056
4057 4057
4058 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4058 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4059 ZoneList<Expression*>* args = expr->arguments(); 4059 ZoneList<Expression*>* args = expr->arguments();
4060 DCHECK_EQ(2, args->length()); 4060 DCHECK_EQ(2, args->length());
4061 VisitForStackValue(args->at(0)); 4061 VisitForStackValue(args->at(0));
(...skipping 1315 matching lines...) Expand 10 before | Expand all | Expand 10 after
5377 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5377 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5378 Assembler::target_address_at(call_target_address, 5378 Assembler::target_address_at(call_target_address,
5379 unoptimized_code)); 5379 unoptimized_code));
5380 return OSR_AFTER_STACK_CHECK; 5380 return OSR_AFTER_STACK_CHECK;
5381 } 5381 }
5382 5382
5383 5383
5384 } } // namespace v8::internal 5384 } } // namespace v8::internal
5385 5385
5386 #endif // V8_TARGET_ARCH_IA32 5386 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698