Chromium Code Reviews

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1028093002: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Turn off --vector-ics flag. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 4089 matching lines...)
4100 __ LoadRoot(result, Heap::kNanValueRootIndex); 4100 __ LoadRoot(result, Heap::kNanValueRootIndex);
4101 __ jmp(&done); 4101 __ jmp(&done);
4102 4102
4103 __ bind(&need_conversion); 4103 __ bind(&need_conversion);
4104 // Load the undefined value into the result register, which will 4104 // Load the undefined value into the result register, which will
4105 // trigger conversion. 4105 // trigger conversion.
4106 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 4106 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
4107 __ jmp(&done); 4107 __ jmp(&done);
4108 4108
4109 NopRuntimeCallHelper call_helper; 4109 NopRuntimeCallHelper call_helper;
4110 generator.GenerateSlow(masm_, call_helper); 4110 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4111 4111
4112 __ bind(&done); 4112 __ bind(&done);
4113 context()->Plug(result); 4113 context()->Plug(result);
4114 } 4114 }
4115 4115
4116 4116
4117 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4117 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4118 ZoneList<Expression*>* args = expr->arguments(); 4118 ZoneList<Expression*>* args = expr->arguments();
4119 DCHECK(args->length() == 2); 4119 DCHECK(args->length() == 2);
4120 VisitForStackValue(args->at(0)); 4120 VisitForStackValue(args->at(0));
(...skipping 26 matching lines...)
4147 __ LoadRoot(result, Heap::kempty_stringRootIndex); 4147 __ LoadRoot(result, Heap::kempty_stringRootIndex);
4148 __ jmp(&done); 4148 __ jmp(&done);
4149 4149
4150 __ bind(&need_conversion); 4150 __ bind(&need_conversion);
4151 // Move smi zero into the result register, which will trigger 4151 // Move smi zero into the result register, which will trigger
4152 // conversion. 4152 // conversion.
4153 __ mov(result, Operand(Smi::FromInt(0))); 4153 __ mov(result, Operand(Smi::FromInt(0)));
4154 __ jmp(&done); 4154 __ jmp(&done);
4155 4155
4156 NopRuntimeCallHelper call_helper; 4156 NopRuntimeCallHelper call_helper;
4157 generator.GenerateSlow(masm_, call_helper); 4157 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4158 4158
4159 __ bind(&done); 4159 __ bind(&done);
4160 context()->Plug(result); 4160 context()->Plug(result);
4161 } 4161 }
4162 4162
4163 4163
4164 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4164 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4165 ZoneList<Expression*>* args = expr->arguments(); 4165 ZoneList<Expression*>* args = expr->arguments();
4166 DCHECK_EQ(2, args->length()); 4166 DCHECK_EQ(2, args->length());
4167 VisitForStackValue(args->at(0)); 4167 VisitForStackValue(args->at(0));
(...skipping 1344 matching lines...)
5512 5512
5513 DCHECK(interrupt_address == 5513 DCHECK(interrupt_address ==
5514 isolate->builtins()->OsrAfterStackCheck()->entry()); 5514 isolate->builtins()->OsrAfterStackCheck()->entry());
5515 return OSR_AFTER_STACK_CHECK; 5515 return OSR_AFTER_STACK_CHECK;
5516 } 5516 }
5517 5517
5518 5518
5519 } } // namespace v8::internal 5519 } } // namespace v8::internal
5520 5520
5521 #endif // V8_TARGET_ARCH_ARM 5521 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine