Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1028093002: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Disable assert. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 4090 matching lines...) Expand 10 before | Expand all | Expand 10 after
4101 __ LoadRoot(result, Heap::kNanValueRootIndex); 4101 __ LoadRoot(result, Heap::kNanValueRootIndex);
4102 __ jmp(&done); 4102 __ jmp(&done);
4103 4103
4104 __ bind(&need_conversion); 4104 __ bind(&need_conversion);
4105 // Load the undefined value into the result register, which will 4105 // Load the undefined value into the result register, which will
4106 // trigger conversion. 4106 // trigger conversion.
4107 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 4107 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
4108 __ jmp(&done); 4108 __ jmp(&done);
4109 4109
4110 NopRuntimeCallHelper call_helper; 4110 NopRuntimeCallHelper call_helper;
4111 generator.GenerateSlow(masm_, call_helper); 4111 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4112 4112
4113 __ bind(&done); 4113 __ bind(&done);
4114 context()->Plug(result); 4114 context()->Plug(result);
4115 } 4115 }
4116 4116
4117 4117
4118 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4118 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4119 ZoneList<Expression*>* args = expr->arguments(); 4119 ZoneList<Expression*>* args = expr->arguments();
4120 DCHECK(args->length() == 2); 4120 DCHECK(args->length() == 2);
4121 4121
(...skipping 28 matching lines...) Expand all
4150 __ LoadRoot(result, Heap::kempty_stringRootIndex); 4150 __ LoadRoot(result, Heap::kempty_stringRootIndex);
4151 __ jmp(&done); 4151 __ jmp(&done);
4152 4152
4153 __ bind(&need_conversion); 4153 __ bind(&need_conversion);
4154 // Move smi zero into the result register, which will trigger 4154 // Move smi zero into the result register, which will trigger
4155 // conversion. 4155 // conversion.
4156 __ li(result, Operand(Smi::FromInt(0))); 4156 __ li(result, Operand(Smi::FromInt(0)));
4157 __ jmp(&done); 4157 __ jmp(&done);
4158 4158
4159 NopRuntimeCallHelper call_helper; 4159 NopRuntimeCallHelper call_helper;
4160 generator.GenerateSlow(masm_, call_helper); 4160 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4161 4161
4162 __ bind(&done); 4162 __ bind(&done);
4163 context()->Plug(result); 4163 context()->Plug(result);
4164 } 4164 }
4165 4165
4166 4166
4167 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4167 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4168 ZoneList<Expression*>* args = expr->arguments(); 4168 ZoneList<Expression*>* args = expr->arguments();
4169 DCHECK_EQ(2, args->length()); 4169 DCHECK_EQ(2, args->length());
4170 VisitForStackValue(args->at(0)); 4170 VisitForStackValue(args->at(0));
(...skipping 1291 matching lines...) Expand 10 before | Expand all | Expand 10 after
5462 Assembler::target_address_at(pc_immediate_load_address)) == 5462 Assembler::target_address_at(pc_immediate_load_address)) ==
5463 reinterpret_cast<uint32_t>( 5463 reinterpret_cast<uint32_t>(
5464 isolate->builtins()->OsrAfterStackCheck()->entry())); 5464 isolate->builtins()->OsrAfterStackCheck()->entry()));
5465 return OSR_AFTER_STACK_CHECK; 5465 return OSR_AFTER_STACK_CHECK;
5466 } 5466 }
5467 5467
5468 5468
5469 } } // namespace v8::internal 5469 } } // namespace v8::internal
5470 5470
5471 #endif // V8_TARGET_ARCH_MIPS 5471 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698