Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 1028093002: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Disable assert. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3989 matching lines...) Expand 10 before | Expand all | Expand 10 after
4000 __ Move(result, Immediate(isolate()->factory()->nan_value())); 4000 __ Move(result, Immediate(isolate()->factory()->nan_value()));
4001 __ jmp(&done); 4001 __ jmp(&done);
4002 4002
4003 __ bind(&need_conversion); 4003 __ bind(&need_conversion);
4004 // Move the undefined value into the result register, which will 4004 // Move the undefined value into the result register, which will
4005 // trigger conversion. 4005 // trigger conversion.
4006 __ Move(result, Immediate(isolate()->factory()->undefined_value())); 4006 __ Move(result, Immediate(isolate()->factory()->undefined_value()));
4007 __ jmp(&done); 4007 __ jmp(&done);
4008 4008
4009 NopRuntimeCallHelper call_helper; 4009 NopRuntimeCallHelper call_helper;
4010 generator.GenerateSlow(masm_, call_helper); 4010 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4011 4011
4012 __ bind(&done); 4012 __ bind(&done);
4013 context()->Plug(result); 4013 context()->Plug(result);
4014 } 4014 }
4015 4015
4016 4016
4017 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4017 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4018 ZoneList<Expression*>* args = expr->arguments(); 4018 ZoneList<Expression*>* args = expr->arguments();
4019 DCHECK(args->length() == 2); 4019 DCHECK(args->length() == 2);
4020 4020
(...skipping 27 matching lines...) Expand all
4048 __ Move(result, Immediate(isolate()->factory()->empty_string())); 4048 __ Move(result, Immediate(isolate()->factory()->empty_string()));
4049 __ jmp(&done); 4049 __ jmp(&done);
4050 4050
4051 __ bind(&need_conversion); 4051 __ bind(&need_conversion);
4052 // Move smi zero into the result register, which will trigger 4052 // Move smi zero into the result register, which will trigger
4053 // conversion. 4053 // conversion.
4054 __ Move(result, Immediate(Smi::FromInt(0))); 4054 __ Move(result, Immediate(Smi::FromInt(0)));
4055 __ jmp(&done); 4055 __ jmp(&done);
4056 4056
4057 NopRuntimeCallHelper call_helper; 4057 NopRuntimeCallHelper call_helper;
4058 generator.GenerateSlow(masm_, call_helper); 4058 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4059 4059
4060 __ bind(&done); 4060 __ bind(&done);
4061 context()->Plug(result); 4061 context()->Plug(result);
4062 } 4062 }
4063 4063
4064 4064
4065 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4065 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4066 ZoneList<Expression*>* args = expr->arguments(); 4066 ZoneList<Expression*>* args = expr->arguments();
4067 DCHECK_EQ(2, args->length()); 4067 DCHECK_EQ(2, args->length());
4068 VisitForStackValue(args->at(0)); 4068 VisitForStackValue(args->at(0));
(...skipping 1315 matching lines...) Expand 10 before | Expand all | Expand 10 after
5384 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5384 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5385 Assembler::target_address_at(call_target_address, 5385 Assembler::target_address_at(call_target_address,
5386 unoptimized_code)); 5386 unoptimized_code));
5387 return OSR_AFTER_STACK_CHECK; 5387 return OSR_AFTER_STACK_CHECK;
5388 } 5388 }
5389 5389
5390 5390
5391 } } // namespace v8::internal 5391 } } // namespace v8::internal
5392 5392
5393 #endif // V8_TARGET_ARCH_IA32 5393 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/mips/code-stubs-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698