Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1028093002: VectorICs: keyed element loads were kicking out non-smi keys unnecessarily (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Disable assert. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 4095 matching lines...) Expand 10 before | Expand all | Expand 10 after
4106 __ LoadRoot(result, Heap::kNanValueRootIndex); 4106 __ LoadRoot(result, Heap::kNanValueRootIndex);
4107 __ jmp(&done); 4107 __ jmp(&done);
4108 4108
4109 __ bind(&need_conversion); 4109 __ bind(&need_conversion);
4110 // Load the undefined value into the result register, which will 4110 // Load the undefined value into the result register, which will
4111 // trigger conversion. 4111 // trigger conversion.
4112 __ LoadRoot(result, Heap::kUndefinedValueRootIndex); 4112 __ LoadRoot(result, Heap::kUndefinedValueRootIndex);
4113 __ jmp(&done); 4113 __ jmp(&done);
4114 4114
4115 NopRuntimeCallHelper call_helper; 4115 NopRuntimeCallHelper call_helper;
4116 generator.GenerateSlow(masm_, call_helper); 4116 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4117 4117
4118 __ bind(&done); 4118 __ bind(&done);
4119 context()->Plug(result); 4119 context()->Plug(result);
4120 } 4120 }
4121 4121
4122 4122
4123 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) { 4123 void FullCodeGenerator::EmitStringCharAt(CallRuntime* expr) {
4124 ZoneList<Expression*>* args = expr->arguments(); 4124 ZoneList<Expression*>* args = expr->arguments();
4125 DCHECK(args->length() == 2); 4125 DCHECK(args->length() == 2);
4126 VisitForStackValue(args->at(0)); 4126 VisitForStackValue(args->at(0));
(...skipping 26 matching lines...) Expand all
4153 __ LoadRoot(result, Heap::kempty_stringRootIndex); 4153 __ LoadRoot(result, Heap::kempty_stringRootIndex);
4154 __ jmp(&done); 4154 __ jmp(&done);
4155 4155
4156 __ bind(&need_conversion); 4156 __ bind(&need_conversion);
4157 // Move smi zero into the result register, which will trigger 4157 // Move smi zero into the result register, which will trigger
4158 // conversion. 4158 // conversion.
4159 __ mov(result, Operand(Smi::FromInt(0))); 4159 __ mov(result, Operand(Smi::FromInt(0)));
4160 __ jmp(&done); 4160 __ jmp(&done);
4161 4161
4162 NopRuntimeCallHelper call_helper; 4162 NopRuntimeCallHelper call_helper;
4163 generator.GenerateSlow(masm_, call_helper); 4163 generator.GenerateSlow(masm_, NOT_PART_OF_IC_HANDLER, call_helper);
4164 4164
4165 __ bind(&done); 4165 __ bind(&done);
4166 context()->Plug(result); 4166 context()->Plug(result);
4167 } 4167 }
4168 4168
4169 4169
4170 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) { 4170 void FullCodeGenerator::EmitStringAdd(CallRuntime* expr) {
4171 ZoneList<Expression*>* args = expr->arguments(); 4171 ZoneList<Expression*>* args = expr->arguments();
4172 DCHECK_EQ(2, args->length()); 4172 DCHECK_EQ(2, args->length());
4173 VisitForStackValue(args->at(0)); 4173 VisitForStackValue(args->at(0));
(...skipping 1344 matching lines...) Expand 10 before | Expand all | Expand 10 after
5518 5518
5519 DCHECK(interrupt_address == 5519 DCHECK(interrupt_address ==
5520 isolate->builtins()->OsrAfterStackCheck()->entry()); 5520 isolate->builtins()->OsrAfterStackCheck()->entry());
5521 return OSR_AFTER_STACK_CHECK; 5521 return OSR_AFTER_STACK_CHECK;
5522 } 5522 }
5523 5523
5524 5524
5525 } } // namespace v8::internal 5525 } } // namespace v8::internal
5526 5526
5527 #endif // V8_TARGET_ARCH_ARM 5527 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm64/code-stubs-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698