Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1028023002: Make the app list speech view query able to span multiple lines. (Closed)

Created:
5 years, 9 months ago by calamity
Modified:
5 years, 9 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, Jun Mukai
Base URL:
https://chromium.googlesource.com/chromium/src.git@content_view_base_class
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the app list speech view query able to span multiple lines. This CL makes the app list speech view query able to span multiple lines. This was made possible by a change in Label which drastically speeds up layout of a label. which has to happen each time the query string changes. BUG=443762 Committed: https://crrev.com/35e95fe3ca6f8ad9b9b037f7d6b69872f740705c Cr-Commit-Position: refs/heads/master@{#321950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/app_list/views/speech_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
calamity
5 years, 9 months ago (2015-03-23 03:40:11 UTC) #2
Matt Giuca
lgtm
5 years, 9 months ago (2015-03-24 06:29:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028023002/1
5 years, 9 months ago (2015-03-24 07:07:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 08:03:15 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 08:03:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35e95fe3ca6f8ad9b9b037f7d6b69872f740705c
Cr-Commit-Position: refs/heads/master@{#321950}

Powered by Google App Engine
This is Rietveld 408576698