Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1027903002: Enable tracing in SkyShell (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enable tracing in SkyShell This CL teaches shelldb how to trace SkyShell. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/261a1cc44d6bb3106e01d190949bddf5ff8e1d55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -3 lines) Patch
M sky/shell/BUILD.gn View 3 chunks +5 lines, -1 line 0 comments Download
M sky/shell/library_loader.cc View 1 chunk +3 lines, -1 line 0 comments Download
M sky/shell/org/domokit/sky/shell/SkyActivity.java View 2 chunks +2 lines, -0 lines 0 comments Download
A sky/shell/org/domokit/sky/shell/TracingController.java View 1 chunk +75 lines, -0 lines 0 comments Download
A sky/shell/tracing_controller.h View 1 chunk +19 lines, -0 lines 0 comments Download
A sky/shell/tracing_controller.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M sky/tools/shelldb View 3 chunks +54 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-20 21:13:37 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-20 21:14:17 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-20 21:16:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
261a1cc44d6bb3106e01d190949bddf5ff8e1d55.

Powered by Google App Engine
This is Rietveld 408576698