Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1027883003: Only call OnActiveWindowChanged() for NotifyNormal FocusIn/FocusOut events. (Closed)

Created:
5 years, 9 months ago by stapelberg
Modified:
5 years, 9 months ago
Reviewers:
Elliot Glaysher, erg
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only call OnActiveWindowChanged() for NotifyNormal FocusIn/FocusOut events. This fixes flickering when switching the X11 input focus between non-chrome windows, but having the pointer be above the chrome window (you need to use keyboard shortcuts to switch focus to trigger this). The reason for the flickering is that OnActiveWindowChanged() is called with state ACTIVE, even though the window was not activated. Before my change, the code called OnActiveWindowChanged() even for FocusIn/FocusOut events with mode==NotifyGrab, which is not intended. For details on the events, see: http://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html Committed: https://crrev.com/a5f6b107185e48a96f1317ca01cec501a32e1f04 Cr-Commit-Position: refs/heads/master@{#321821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
stapelberg
5 years, 9 months ago (2015-03-22 14:41:18 UTC) #2
Elliot Glaysher
lgtm
5 years, 9 months ago (2015-03-23 17:48:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027883003/1
5 years, 9 months ago (2015-03-23 18:05:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 18:48:53 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 18:49:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5f6b107185e48a96f1317ca01cec501a32e1f04
Cr-Commit-Position: refs/heads/master@{#321821}

Powered by Google App Engine
This is Rietveld 408576698