Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1027863002: Move provisional navigation parameters to RenderFrame, and use the HistoryController to distribute … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/history_controller.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index cbe833d947714282085cf70b93a6cbfa66ad0837..4f93aadae3e22dd3648884984a13ab1249c4bd9b 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -74,6 +74,7 @@ namespace content {
class ChildFrameCompositingHelper;
class CompositorDependencies;
+class DocumentState;
class ExternalPopupMenu;
class GeolocationDispatcher;
class ManifestManager;
@@ -81,6 +82,7 @@ class MediaStreamDispatcher;
class MediaStreamRendererFactory;
class MediaPermissionDispatcher;
class MidiDispatcher;
+class NavigationState;
class NotificationPermissionDispatcher;
class PageState;
class PepperPluginInstanceImpl;
@@ -101,6 +103,7 @@ enum class SandboxFlags;
struct CommonNavigationParams;
struct CustomContextMenuContext;
struct FrameReplicationState;
+struct NavigationParams;
struct RequestNavigationParams;
struct ResourceResponseHead;
struct StartNavigationParams;
@@ -541,6 +544,11 @@ class CONTENT_EXPORT RenderFrameImpl
ManifestManager* manifest_manager();
+ // TODO(creis): Remove when the only caller, the HistoryController, is no
+ // more.
+ void SetPendingNavigationParams(
+ scoped_ptr<NavigationParams> navigation_params);
+
protected:
RenderFrameImpl(RenderViewImpl* render_view, int32 routing_id);
@@ -719,6 +727,14 @@ class CONTENT_EXPORT RenderFrameImpl
// Returns the URL being loaded by the |frame_|'s request.
GURL GetLoadingUrl() const;
+ // If we initiated a navigation, this function will populate |document_state|
+ // with the navigation information saved in OnNavigate().
+ void PopulateDocumentStateFromPending(DocumentState* document_state);
+
+ // Returns a new NavigationState populated with the navigation information
+ // saved in OnNavigate().
+ NavigationState* CreateNavigationStateFromPending();
+
#if defined(OS_ANDROID)
blink::WebMediaPlayer* CreateAndroidWebMediaPlayer(
const blink::WebURL& url,
@@ -761,6 +777,11 @@ class CONTENT_EXPORT RenderFrameImpl
// own RenderWidgets.
scoped_refptr<RenderWidget> render_widget_;
+ // Temporarily holds state pertaining to a navigation that has been initiated
+ // until the NavigationState corresponding to the new navigation is created in
+ // didCreateDataSource().
+ scoped_ptr<NavigationParams> pending_navigation_params_;
+
#if defined(ENABLE_PLUGINS)
// Current text input composition text. Empty if no composition is in
// progress.
« no previous file with comments | « content/renderer/history_controller.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698