Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1027843003: Fix enum for GoogleUpdate.InfoBar. (Closed)

Created:
5 years, 9 months ago by Yaron
Modified:
5 years, 9 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix enum for GoogleUpdate.InfoBar. I had two cases flipped. BUG=463658 Committed: https://crrev.com/9cb25622f4b0f9773a404f465babedf72e168529 Cr-Commit-Position: refs/heads/master@{#321630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yaron
5 years, 9 months ago (2015-03-20 18:12:15 UTC) #2
Mark P
lgtm
5 years, 9 months ago (2015-03-20 19:04:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027843003/1
5 years, 9 months ago (2015-03-20 19:17:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 20:57:53 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 20:58:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cb25622f4b0f9773a404f465babedf72e168529
Cr-Commit-Position: refs/heads/master@{#321630}

Powered by Google App Engine
This is Rietveld 408576698