Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1027843002: [renderer] Fix Task Queue Manager trace events. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org, alex clarke (OOO till 29th)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[renderer] Fix Task Queue Manager trace events. Adds a missing EndArray() to the TaskQueue::AsValueInto introduced in r321183 Committed: https://crrev.com/ea4ff17fe88cbf990cc56ec9cb5e6fb8dccfd78c Cr-Commit-Position: refs/heads/master@{#321588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/scheduler/task_queue_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
rmcilroy
Here is the fix, PTAL, thanks.
5 years, 9 months ago (2015-03-20 16:25:31 UTC) #2
Sami
Neat, thanks! lgtm.
5 years, 9 months ago (2015-03-20 16:29:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027843002/1
5 years, 9 months ago (2015-03-20 16:30:04 UTC) #5
alex clarke (OOO till 29th)
lgtm
5 years, 9 months ago (2015-03-20 16:30:06 UTC) #7
alex clarke (OOO till 29th)
lgtm
5 years, 9 months ago (2015-03-20 16:30:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 17:27:44 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 17:28:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea4ff17fe88cbf990cc56ec9cb5e6fb8dccfd78c
Cr-Commit-Position: refs/heads/master@{#321588}

Powered by Google App Engine
This is Rietveld 408576698