Port Android relocation packer to chromium build

Port Android relocation packer to chromium build

- Copy Android relocation packer source from AOSP:
    bionic/tools/relocation_packer/
- Remove golden test data generation scripts (not needed here)
- Add a local ScopedFd.h, to avoid any dependency on base
- Add gyp and gn build files for chromium
- Update third_party/android_platform/README.chromium

BUG=385553
R=rmcilroy@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/418115b3467e12e606e6e48ac3532f583e9f09ac

[simonb (inactive), 2015-03-20 16:38:14]

simonb@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2015-03-20 17:38:26]

Didn't look at the actual relocation packer code. The rest looks reasonable but
a couple of comments.

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
File third_party/android_platform/BUILD.gn (right):

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/BUILD.gn:37: # Note: unit test target suppressed
due to current absence of gn target for:
Is there a bug for this you can point to?

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
File third_party/android_platform/README.chromium (right):

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/README.chromium:32: Copy sources from AOSP
bionic/tools/relocation_packer
Can you put the relocation packer in the same directory structure as the android
tool (i.e., bionic/tools/relocation_packer).

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
File third_party/android_platform/relocation_packer.gyp (right):

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/relocation_packer.gyp:21:
'relocation_packer/src/sleb128.cc',
Could you pull out the sources into a gypi file which sets them as a variable
and that way they can be shared by both gn and gyp.

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/relocation_packer.gyp:38: # GN:
//tools/relocation_packer:relocation_packer_unittests
Maybe better to do a TODO(GN) here (and remove the GN code) to make it obvious
that this needs to be added.

[simonb (inactive), 2015-03-20 18:33:24]

Thanks.  PTAL when ready.

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
File third_party/android_platform/BUILD.gn (right):

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/BUILD.gn:37: # Note: unit test target suppressed
due to current absence of gn target for:
On 2015/03/20 17:38:26, rmcilroy wrote:
> Is there a bug for this you can point to?

None that I'm aware of.  AFAIK it's just Not Done Yet.

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
File third_party/android_platform/README.chromium (right):

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/README.chromium:32: Copy sources from AOSP
bionic/tools/relocation_packer
On 2015/03/20 17:38:26, rmcilroy wrote:
> Can you put the relocation packer in the same directory structure as the
android
> tool (i.e., bionic/tools/relocation_packer).

Done.

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
File third_party/android_platform/relocation_packer.gyp (right):

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/relocation_packer.gyp:21:
'relocation_packer/src/sleb128.cc',
On 2015/03/20 17:38:26, rmcilroy wrote:
> Could you pull out the sources into a gypi file which sets them as a variable
> and that way they can be shared by both gn and gyp.

Done.  (Specifically, pulled from variables within the main gyp file.)

https://codereview.chromium.org/1027823002/diff/1/third_party/android_platfor...
third_party/android_platform/relocation_packer.gyp:38: # GN:
//tools/relocation_packer:relocation_packer_unittests
On 2015/03/20 17:38:26, rmcilroy wrote:
> Maybe better to do a TODO(GN) here (and remove the GN code) to make it obvious
> that this needs to be added.

Done.

[rmcilroy, 2015-03-24 11:13:19]

lgtm, thanks.

https://codereview.chromium.org/1027823002/diff/60001/third_party/android_pla...
File third_party/android_platform/relocation_packer.gyp (right):

https://codereview.chromium.org/1027823002/diff/60001/third_party/android_pla...
third_party/android_platform/relocation_packer.gyp:31: # GN:
//tools/relocation_packer:lib_relocation_packer
Should this be
//third_party/android_platform/relocation_packer:lib_relocation_packer ?

[simonb (inactive), 2015-03-24 16:54:45]

https://codereview.chromium.org/1027823002/diff/60001/third_party/android_pla...
File third_party/android_platform/relocation_packer.gyp (right):

https://codereview.chromium.org/1027823002/diff/60001/third_party/android_pla...
third_party/android_platform/relocation_packer.gyp:31: # GN:
//tools/relocation_packer:lib_relocation_packer
On 2015/03/24 11:13:19, rmcilroy wrote:
> Should this be
> //third_party/android_platform/relocation_packer:lib_relocation_packer ?

It should have been
//third_party/android_platform:android_lib_relocation_packer.  Thanks.  Done.

[simonb (inactive), 2015-03-24 16:55:08]

The CQ bit was checked by simonb@chromium.org

[simonb (inactive), 2015-03-24 16:55:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1027823002/#ps80001
(title: "Fix GN/GYP crossreferences.")

[commit-bot: I haz the power, 2015-03-24 16:55:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1027823002/80001

[commit-bot: I haz the power, 2015-03-24 17:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 17:03:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2015-03-26 16:49:14]

Patchset 6 (id:??) landed as
https://crrev.com/418115b3467e12e606e6e48ac3532f583e9f09ac
Cr-Commit-Position: refs/heads/master@{#322401}

[simonb (inactive), 2015-03-26 16:49:39]

Committed patchset #6 (id:100001) manually as
418115b3467e12e606e6e48ac3532f583e9f09ac (presubmit successful).