Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1027813002: Introduce Scaffold to Sky framework (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel, rafaelw, ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Introduce Scaffold to Sky framework This CL extracts a Scaffold component from StockApp. The Scaffold component lets you create an "app-like" layout with an action bar, a drawer, etc. R=ojan@chromium.org, rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2a63887add8653e44e737195530dc154433b3f83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -42 lines) Patch
M sky/examples/stocks-fn/lib/stock_app.dart View 6 chunks +13 lines, -33 lines 0 comments Download
M sky/framework/components/drawer.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M sky/framework/components/floating_action_button.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A sky/framework/components/scaffold.dart View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
abarth-chromium
5 years, 9 months ago (2015-03-20 16:17:05 UTC) #1
ojan
lgtm
5 years, 9 months ago (2015-03-20 16:32:14 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 2a63887add8653e44e737195530dc154433b3f83 (presubmit successful).
5 years, 9 months ago (2015-03-20 16:34:12 UTC) #4
eseidel
5 years, 9 months ago (2015-03-20 16:55:14 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698