Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102773002: Open non browser window on the target display (Closed)

Created:
7 years ago by oshima
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Visibility:
Public.

Description

Open non browser window on the target display unless the bounds is specified (such as apps window) BUG=314634 TEST=covered by test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239638

Patch Set 1 : #

Total comments: 6

Patch Set 2 : addressed comments #

Patch Set 3 : exclude win7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -54 lines) Patch
M ash/scoped_target_root_window.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.h View 1 5 chunks +33 lines, -14 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 1 10 chunks +75 lines, -30 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 2 3 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 4 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
7 years ago (2013-12-07 00:25:54 UTC) #1
sky
https://codereview.chromium.org/102773002/diff/250001/chrome/browser/ui/window_sizer/window_sizer.cc File chrome/browser/ui/window_sizer/window_sizer.cc (right): https://codereview.chromium.org/102773002/diff/250001/chrome/browser/ui/window_sizer/window_sizer.cc#newcode161 chrome/browser/ui/window_sizer/window_sizer.cc:161: const gfx::Screen* screen_; I don't think you use this. ...
7 years ago (2013-12-07 00:40:28 UTC) #2
oshima
https://codereview.chromium.org/102773002/diff/250001/chrome/browser/ui/window_sizer/window_sizer.cc File chrome/browser/ui/window_sizer/window_sizer.cc (right): https://codereview.chromium.org/102773002/diff/250001/chrome/browser/ui/window_sizer/window_sizer.cc#newcode161 chrome/browser/ui/window_sizer/window_sizer.cc:161: const gfx::Screen* screen_; On 2013/12/07 00:40:28, sky wrote: > ...
7 years ago (2013-12-07 01:01:38 UTC) #3
sky
LGTM
7 years ago (2013-12-08 18:17:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/102773002/270001
7 years ago (2013-12-09 06:49:06 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=233145
7 years ago (2013-12-09 10:36:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/102773002/270001
7 years ago (2013-12-09 15:36:13 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=233268
7 years ago (2013-12-09 19:38:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/102773002/290001
7 years ago (2013-12-09 19:41:25 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-10 01:49:06 UTC) #10
Message was sent while issue was closed. 
Change committed as 239638

Powered by Google App Engine
This is Rietveld 408576698