Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: net/socket/socks_client_socket_pool_unittest.cc

Issue 1027693004: Delete the ClientSocketPoolHistograms class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small xml fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/socks_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/socks_client_socket_pool_unittest.cc
diff --git a/net/socket/socks_client_socket_pool_unittest.cc b/net/socket/socks_client_socket_pool_unittest.cc
index 391d31beddb87f16dbf3a1268402af56a3279dd9..e841c83635d7fc3813e1b08a7f01c5156481bbc2 100644
--- a/net/socket/socks_client_socket_pool_unittest.cc
+++ b/net/socket/socks_client_socket_pool_unittest.cc
@@ -14,7 +14,6 @@
#include "net/dns/mock_host_resolver.h"
#include "net/socket/client_socket_factory.h"
#include "net/socket/client_socket_handle.h"
-#include "net/socket/client_socket_pool_histograms.h"
#include "net/socket/socket_test_util.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -90,18 +89,14 @@ class SOCKSClientSocketPoolTest : public testing::Test {
};
SOCKSClientSocketPoolTest()
- : transport_histograms_("MockTCP"),
- transport_socket_pool_(
- kMaxSockets, kMaxSocketsPerGroup,
- &transport_histograms_,
- &transport_client_socket_factory_),
- socks_histograms_("SOCKSUnitTest"),
- pool_(kMaxSockets, kMaxSocketsPerGroup,
- &socks_histograms_,
+ : transport_socket_pool_(kMaxSockets,
+ kMaxSocketsPerGroup,
+ &transport_client_socket_factory_),
+ pool_(kMaxSockets,
+ kMaxSocketsPerGroup,
&host_resolver_,
&transport_socket_pool_,
- NULL) {
- }
+ NULL) {}
~SOCKSClientSocketPoolTest() override {}
@@ -116,11 +111,9 @@ class SOCKSClientSocketPoolTest : public testing::Test {
ScopedVector<TestSocketRequest>* requests() { return test_base_.requests(); }
- ClientSocketPoolHistograms transport_histograms_;
MockClientSocketFactory transport_client_socket_factory_;
MockTransportClientSocketPool transport_socket_pool_;
- ClientSocketPoolHistograms socks_histograms_;
MockHostResolver host_resolver_;
SOCKSClientSocketPool pool_;
ClientSocketPoolTest test_base_;
« no previous file with comments | « net/socket/socks_client_socket_pool.cc ('k') | net/socket/ssl_client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698