Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: net/socket/client_socket_pool_base.h

Issue 1027693004: Delete the ClientSocketPoolHistograms class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small xml fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/client_socket_pool.h ('k') | net/socket/client_socket_pool_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_pool_base.h
diff --git a/net/socket/client_socket_pool_base.h b/net/socket/client_socket_pool_base.h
index 76ae919f18954db71b2bfab0ce0ee2db50427e93..5270155081bc88cb5f1d670f32e8b8ce0803c03a 100644
--- a/net/socket/client_socket_pool_base.h
+++ b/net/socket/client_socket_pool_base.h
@@ -702,17 +702,17 @@ class ClientSocketPoolBase {
// long to leave an unused idle socket open before closing it.
// |used_idle_socket_timeout| specifies how long to leave a previously used
// idle socket open before closing it.
- ClientSocketPoolBase(
- HigherLayeredPool* self,
- int max_sockets,
- int max_sockets_per_group,
- ClientSocketPoolHistograms* histograms,
- base::TimeDelta unused_idle_socket_timeout,
- base::TimeDelta used_idle_socket_timeout,
- ConnectJobFactory* connect_job_factory)
- : histograms_(histograms),
- helper_(self, max_sockets, max_sockets_per_group,
- unused_idle_socket_timeout, used_idle_socket_timeout,
+ ClientSocketPoolBase(HigherLayeredPool* self,
+ int max_sockets,
+ int max_sockets_per_group,
+ base::TimeDelta unused_idle_socket_timeout,
+ base::TimeDelta used_idle_socket_timeout,
+ ConnectJobFactory* connect_job_factory)
+ : helper_(self,
+ max_sockets,
+ max_sockets_per_group,
+ unused_idle_socket_timeout,
+ used_idle_socket_timeout,
new ConnectJobFactoryAdaptor(connect_job_factory)) {}
virtual ~ClientSocketPoolBase() {}
@@ -824,10 +824,6 @@ class ClientSocketPoolBase {
return helper_.ConnectionTimeout();
}
- ClientSocketPoolHistograms* histograms() const {
- return histograms_;
- }
-
void EnableConnectBackupJobs() { helper_.EnableConnectBackupJobs(); }
bool CloseOneIdleSocket() { return helper_.CloseOneIdleSocket(); }
@@ -868,8 +864,6 @@ class ClientSocketPoolBase {
const scoped_ptr<ConnectJobFactory> connect_job_factory_;
};
- // Histograms for the pool
- ClientSocketPoolHistograms* const histograms_;
internal::ClientSocketPoolBaseHelper helper_;
DISALLOW_COPY_AND_ASSIGN(ClientSocketPoolBase);
« no previous file with comments | « net/socket/client_socket_pool.h ('k') | net/socket/client_socket_pool_base_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698