Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: net/socket/client_socket_handle.cc

Issue 1027693004: Delete the ClientSocketPoolHistograms class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small xml fix Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/net.gypi ('k') | net/socket/client_socket_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_handle.cc
diff --git a/net/socket/client_socket_handle.cc b/net/socket/client_socket_handle.cc
index 53bcd77499a0afa27242f29811ccbd128a5f2f1f..734e58aeffff7369f6547ec84a98d8307d10d26e 100644
--- a/net/socket/client_socket_handle.cc
+++ b/net/socket/client_socket_handle.cc
@@ -11,7 +11,6 @@
#include "base/logging.h"
#include "net/base/net_errors.h"
#include "net/socket/client_socket_pool.h"
-#include "net/socket/client_socket_pool_histograms.h"
namespace net {
@@ -149,8 +148,6 @@ scoped_ptr<StreamSocket> ClientSocketHandle::PassSocket() {
void ClientSocketHandle::HandleInitCompletion(int result) {
CHECK_NE(ERR_IO_PENDING, result);
- ClientSocketPoolHistograms* histograms = pool_->histograms();
- histograms->AddErrorCode(result);
if (result != OK) {
if (!socket_.get())
ResetInternal(false); // Nothing to cancel since the request failed.
@@ -162,22 +159,6 @@ void ClientSocketHandle::HandleInitCompletion(int result) {
CHECK_NE(-1, pool_id_) << "Pool should have set |pool_id_| to a valid value.";
setup_time_ = base::TimeTicks::Now() - init_time_;
- histograms->AddSocketType(reuse_type());
- switch (reuse_type()) {
- case ClientSocketHandle::UNUSED:
- histograms->AddRequestTime(setup_time());
- break;
- case ClientSocketHandle::UNUSED_IDLE:
- histograms->AddUnusedIdleTime(idle_time());
- break;
- case ClientSocketHandle::REUSED_IDLE:
- histograms->AddReusedIdleTime(idle_time());
- break;
- default:
- NOTREACHED();
- break;
- }
-
// Broadcast that the socket has been acquired.
// TODO(eroman): This logging is not complete, in particular set_socket() and
// release() socket. It ends up working though, since those methods are being
« no previous file with comments | « net/net.gypi ('k') | net/socket/client_socket_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698