Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1027693004: Delete the ClientSocketPoolHistograms class. (Closed)

Created:
5 years, 9 months ago by rkaplow
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete the ClientSocketPoolHistograms class. This class write the Net.SocketIdleTimeBeforeNextUse_ReusedSocket Net.SocketIdleTimeBeforeNextUse_UnusedSocket Net.SocketInitErrorCodes Net.SocketRequestTime Net.SocketType histograms. This histograms are all unowned, and have a large cumulative load on user bandwidth and internal google servers. Are these histograms used at all? It appears they have not been used for some time (based on lack of ownership) BUG=469288 Committed: https://crrev.com/d90695c943f92eac547ee04ad0913f6e316258de Cr-Commit-Position: refs/heads/master@{#322244}

Patch Set 1 #

Patch Set 2 : small xml fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -385 lines) Patch
M net/http/http_network_transaction_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.h View 3 chunks +0 lines, -4 lines 0 comments Download
M net/http/http_proxy_client_socket_pool.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/client_socket_handle.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M net/socket/client_socket_pool.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 3 chunks +11 lines, -17 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 6 chunks +6 lines, -12 lines 0 comments Download
D net/socket/client_socket_pool_histograms.h View 1 chunk +0 lines, -46 lines 0 comments Download
D net/socket/client_socket_pool_histograms.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.h View 3 chunks +0 lines, -19 lines 0 comments Download
M net/socket/client_socket_pool_manager_impl.cc View 9 chunks +5 lines, -24 lines 0 comments Download
M net/socket/deterministic_socket_data_unittest.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M net/socket/socks_client_socket_pool.h View 3 chunks +0 lines, -4 lines 0 comments Download
M net/socket/socks_client_socket_pool.cc View 2 chunks +7 lines, -11 lines 0 comments Download
M net/socket/socks_client_socket_pool_unittest.cc View 3 chunks +6 lines, -13 lines 0 comments Download
M net/socket/ssl_client_socket_pool.h View 3 chunks +0 lines, -4 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 6 chunks +2 lines, -15 lines 0 comments Download
M net/socket/transport_client_socket_pool.h View 3 chunks +0 lines, -3 lines 0 comments Download
M net/socket/transport_client_socket_pool.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M net/socket/transport_client_socket_pool_unittest.cc View 11 chunks +0 lines, -12 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool.h View 4 chunks +0 lines, -4 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M net/socket/websocket_transport_client_socket_pool_unittest.cc View 12 chunks +0 lines, -13 lines 0 comments Download
M net/websockets/websocket_basic_stream_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/websockets/websocket_handshake_stream_create_helper_test.cc View 2 chunks +1 line, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
rkaplow
isherman@chromium.org: Please review changes in histograms cbentzel@chromium.org: Please review changes in All
5 years, 9 months ago (2015-03-20 19:51:27 UTC) #2
Ilya Sherman
histograms.xml lgtm
5 years, 9 months ago (2015-03-20 19:57:09 UTC) #3
rkaplow
5 years, 9 months ago (2015-03-23 15:52:30 UTC) #5
rkaplow
On 2015/03/23 15:52:30, rkaplow wrote: Is there a better person to review this CL?
5 years, 9 months ago (2015-03-24 14:49:53 UTC) #6
mmenke
LGTM. I think we can safely get rid of all of these. We may want ...
5 years, 9 months ago (2015-03-25 15:41:13 UTC) #7
mmenke
On 2015/03/25 15:41:13, mmenke wrote: > LGTM. > > I think we can safely get ...
5 years, 9 months ago (2015-03-25 15:42:00 UTC) #8
rkaplow
On 2015/03/25 15:42:00, mmenke wrote: > On 2015/03/25 15:41:13, mmenke wrote: > > LGTM. > ...
5 years, 9 months ago (2015-03-25 20:51:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027693004/20001
5 years, 9 months ago (2015-03-25 20:51:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-25 22:13:13 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 22:13:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d90695c943f92eac547ee04ad0913f6e316258de
Cr-Commit-Position: refs/heads/master@{#322244}

Powered by Google App Engine
This is Rietveld 408576698